8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

[dholmes-ora]

Please see bug report for gory details.

For the specific issue here of the vm_assert gtests I propose to make two changes to the VM:

1. When core dumps are disabled, os::abort should call ::_exit not ::exit, as the former more closely models the abrupt termination of ::abort() but without the core dump.

2. The race condition when SupressFatalErrorMessages is true is fixed by placing the check after the atomic set/check of the thread-id. That way only a single thread can trigger the fatal error processing.

I was debating whether to make a slight change so that even when SuppressFatalErrorMessage is true, secondary failures will report that such an error occurred but not with any details. But I've left the existing silence for now. It is possible someone uses the flag to hide a message I would like to expose. I suppose adding additional output in debug builds only may be an option - options welcomed.

Testing:

• fully manual

I manually set up the conditions where a background thread could crash due to the atexit actions executing. I added special debug code to show what was happening in such cases, and that secondary errors were occurring. I then applied the fix for #2 and saw the second thread getting caught; then I applied fix #1 and the secondary crashes were gone.

Also did tier 1-3 testing and local gtest testing just to sanity check things.

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/3002/head:pull/3002
$ git checkout pull/3002

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

/label add hotspot-runtime

[openjdk]

@dholmes-ora
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (91405ea)

[dcubed-ojdk]

Thumbs up.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Reviewed-by: dcubed, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 1e57087: 8263392: Allow current thread to be specified in ExceptionMark
• 4d1c08c: 8263616: 'Deprecatd' typo in src/hotspot/share/classfile/classFileParser.cpp
• 0c718ab: 8262277: URLClassLoader.getResource throws undocumented IllegalArgumentException
• 4f1cda4: 8263387: G1GarbageCollection JFR event gets gc phase, not gc type
• 5ab5244: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE
• 771b146: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert
• 46d78f0: 6539707: (fc) MappedByteBuffer.force() method throws an IOException in a very simple test
• 189289d: 8262326: MaxMetaspaceSize does not have to be aligned to metaspace commit alignment
• d825198: 8263556: remove @modules java.base from tests
• d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/554dd29fb67b9a25ad161920b57e238c06024938...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

This looks good.

[dholmes-ora]

Thanks for the quick reviews @dcubed-ojdk and @coleenp !

[dholmes-ora]

/integrate

[openjdk]

@dholmes-ora Since your change was applied there have been 20 commits pushed to the master branch:

• 1e57087: 8263392: Allow current thread to be specified in ExceptionMark
• 4d1c08c: 8263616: 'Deprecatd' typo in src/hotspot/share/classfile/classFileParser.cpp
• 0c718ab: 8262277: URLClassLoader.getResource throws undocumented IllegalArgumentException
• 4f1cda4: 8263387: G1GarbageCollection JFR event gets gc phase, not gc type
• 5ab5244: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE
• 771b146: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert
• 46d78f0: 6539707: (fc) MappedByteBuffer.force() method throws an IOException in a very simple test
• 189289d: 8262326: MaxMetaspaceSize does not have to be aligned to metaspace commit alignment
• d825198: 8263556: remove @modules java.base from tests
• d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/554dd29fb67b9a25ad161920b57e238c06024938...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8c1112a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.