Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION #3010

Closed
wants to merge 3 commits into from

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Mar 15, 2021

When returning from the last Java frame back to vm and hitting a safepoint poll on that last return we sometimes have a last java frame but no vframe.
This seem to be a bug in itself, handled in: 8263576

Other places which uses vframe NULL checks it before, so let's do that in GetCurrentLocationClosure also.

Testing: nsk jdi/jvmti, jdk jdi, jck vm and t1-3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/3010/head:pull/3010
$ git checkout pull/3010

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 15, 2021

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@robehn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 15, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up!

I agree that the code should have checked for "if (vf != NULL) {"
instead of asserting that "(vf != NULL)".

src/hotspot/share/prims/jvmtiEnvThreadState.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION

Reviewed-by: dcubed, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 15, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Robbin,
The fix looks good to me. Thank you for taking care about this issue!
Thanks,
Serguei

@robehn
Copy link
Contributor Author

@robehn robehn commented Mar 16, 2021

Thumbs up!

I agree that the code should have checked for "if (vf != NULL) {"
instead of asserting that "(vf != NULL)".

Thanks Dan!

@robehn
Copy link
Contributor Author

@robehn robehn commented Mar 16, 2021

Robbin,
The fix looks good to me. Thank you for taking care about this issue!
Thanks,
Serguei

Thanks Serguei!

@robehn
Copy link
Contributor Author

@robehn robehn commented Mar 17, 2021

/integrate

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@robehn Since your change was applied there have been 21 commits pushed to the master branch:

  • d2144a5: 8263058: Optimize vector shift with zero shift count
  • dd6c911: 8263705: Two shenandoah tests fail due to can't find ClassFileInstaller
  • 4acb883: 8261666: [mlvm] Remove WhiteBoxHelper
  • 5069796: 8263164: assert(_base >= VectorA && _base <= VectorZ) failed: Not a Vector while calling StoreVectorNode::memory_size()
  • 996079b: 8260650: test failed with "assert(false) failed: infinite loop in PhaseIterGVN::optimize"
  • 9cb9af6: 8260959: remove RECORDS from PreviewFeature.Feature enum
  • 05fe06a: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • 422eba8: 8263536: Add @build tags to jpackage tests
  • 0d2f87e: 8263562: Checking if proxy_klass_head is still lambda_proxy_is_available
  • a67a679: 8263679: C1: Remove vtable call
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/c484d8904285652246c3af212a4211b9a8955149...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7b9d256.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the 8261262 branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants