-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions #3015
Conversation
…nts who should be ignored in a11y interactions Initial implementation Moved the CAccessibility ignore list initialization into the new classes
👋 Welcome back kizune! A progress list of the required criteria for merging this PR into |
@azuev-java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@@ -286,39 +283,6 @@ + (void)initialize | |||
if (sRoles == nil) { | |||
initializeRoles(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to delete the JavaAccessibilityIgnore roles from the "sRoles"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not right now, there is a legacy code that still uses it and until i am ready to remove all of it i want to keep everything functioning - if anything for the comparison stakes. In the end the entire sRoles map will be eliminated.
@azuev-java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 337 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@azuev-java Since your change was applied there have been 353 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e543a50. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Initial implementation
Moved the CAccessibility ignore list initialization to the new code
Some cleanup
Expose a new API - isAccessibilityElement instead of deprecated accessibilityIsIgnored
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3015/head:pull/3015
$ git checkout pull/3015
To update a local copy of the PR:
$ git checkout pull/3015
$ git pull https://git.openjdk.java.net/jdk pull/3015/head