8263590: Rawtypes warnings should be produced for pattern matching in instanceof

[lahodaj]

For code like:

Object o = null;
boolean b = o instanceof List l;

There should be a raw-type warning for List, as we are effectively declaring a variable with a raw type.

Code like:

Object o = null;
boolean b = o instanceof List;

Will not produce a warning (as it doesn't so far), as the (raw) type is not used in a problematic context.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263590: Rawtypes warnings should be produced for pattern matching in instanceof

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/3016/head:pull/3016
$ git checkout pull/3016

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4b31a4d)

[mcimadamore]

Looks good!

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263590: Rawtypes warnings should be produced for pattern matching in instanceof

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 4f1cda4: 8263387: G1GarbageCollection JFR event gets gc phase, not gc type
• 5ab5244: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE
• 771b146: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert
• 46d78f0: 6539707: (fc) MappedByteBuffer.force() method throws an IOException in a very simple test
• 189289d: 8262326: MaxMetaspaceSize does not have to be aligned to metaspace commit alignment
• d825198: 8263556: remove @modules java.base from tests
• d6b5e18: 8263191: Consolidate ThreadInVMfromJavaNoAsyncException and ThreadBlockInVMWithDeadlockCheck with existing wrappers
• 80cdf78: 8263544: Unused argument in ConstantPoolCacheEntry::set_field()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

@lahodaj Since your change was applied there have been 65 commits pushed to the master branch:

• ff52f29: 8260716: Assert in MacroAssembler::clear_mem with -XX:-IdealizeClearArrayNode
• 72b82fd: 8263725: JFR oldobject tests are not run when GCs are specified explicitly
• 444a80b: 8263455: NMT: assert on registering a region which completely engulfs an existing region
• 2b93ae0: 8261480: MetaspaceShared::preload_and_dump should check exceptions
• 81ba578: 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()
• 9225a23: 8263108: Class initialization deadlock in java.lang.constant
• 5d5813a: 8263757: Remove serviceability/sa/ClhsdClasses.java from ZGC problem list
• 50ff0d4: 8263756: Fix ZGC ProblemList entry for serviceability/sa/ClhsdbSymbol.java
• 99b39aa: 8262807: Note assumptions of core reflection modeling and parameter handling
• 26234b5: 8254979: Class.getSimpleName() returns non-empty for lambda and method
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/c0176c42dcb013e966ec5a9709a46dc9845ac2d9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9cd21b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.