New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261673: Move javadoc for the lookup mechanism to module-info #3020
Conversation
|
@JoeWang-Java this pull request will not be integrated until the CSR request JDK-8263611 for issue JDK-8261673 has been approved. |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java
Outdated
Show resolved
Hide resolved
src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice consolidation. I've added myself as a reviewer of the CSR too.
@JoeWang-Java This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 112 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@JoeWang-Java Since your change was applied there have been 117 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 289d48a. |
Consolidate and move javadoc for the lookup mechanism to the module summary.
/csr
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3020/head:pull/3020
$ git checkout pull/3020
To update a local copy of the PR:
$ git checkout pull/3020
$ git pull https://git.openjdk.java.net/jdk pull/3020/head