Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer #3034

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Mar 16, 2021

Please review this trivial change. Note that the change is not accompanied by a dedicated test. I don't think such a test would be warranted.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/3034/head:pull/3034
$ git checkout pull/3034

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 16, 2021
@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@pavelrappo The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Mar 16, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

lgtm

@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • dc93138: 8256732: Zero: broken +ZeroTLAB exposes badly initialized memory
  • e33bfb3: 8263450: Simplify LambdaForm.useCount
  • 75ef6f5: 8263427: Shenandoah: Trigger weak-LRB even when heap is stable
  • 4517d72: 8263612: Unused variables in C1 runtime
  • 83a9a02: 8263509: LdapSchemaParser.readNextTag checks array length incorrectly
  • 9c50b8e: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
  • 68deb24: 8080272: Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy
  • a31a23d: 8263595: Remove oop type punning in JavaCallArguments
  • a1f6591: 8263589: Introduce JavaValue::get_oop/set_oop
  • 20297a1: 8263577: C2: reachable nodes shouldn't have dead uses at the end of optimizations
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/c0176c42dcb013e966ec5a9709a46dc9845ac2d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2021
@pavelrappo
Copy link
Member Author

pavelrappo commented Mar 16, 2021

@vicente-romero-oracle thanks for reviewing this. I note that although that class could be promoted to a record, it should be done separately when mass-retrofitting compiler code with newer language features.

@pavelrappo
Copy link
Member Author

pavelrappo commented Mar 17, 2021

/integrate

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2021
@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@pavelrappo Since your change was applied there have been 41 commits pushed to the master branch:

  • d1baed6: 8263672: fatal error: no reachable node should have no use
  • 086a66a: 8261095: Add test for clhsdb "symbol" command
  • ec95a5c: 8263410: ListModel javadoc refers to non-existent interface
  • 7b9d256: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • d2144a5: 8263058: Optimize vector shift with zero shift count
  • dd6c911: 8263705: Two shenandoah tests fail due to can't find ClassFileInstaller
  • 4acb883: 8261666: [mlvm] Remove WhiteBoxHelper
  • 5069796: 8263164: assert(_base >= VectorA && _base <= VectorZ) failed: Not a Vector while calling StoreVectorNode::memory_size()
  • 996079b: 8260650: test failed with "assert(false) failed: infinite loop in PhaseIterGVN::optimize"
  • 9cb9af6: 8260959: remove RECORDS from PreviewFeature.Feature enum
  • ... and 31 more: https://git.openjdk.java.net/jdk/compare/c0176c42dcb013e966ec5a9709a46dc9845ac2d9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 23fc2a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pavelrappo pavelrappo deleted the 8263688 branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants