New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8262807: Note assumptions of core reflection modeling and parameter handling #3036
Conversation
|
Webrevs
|
* modifiers present in the {@code class} file representation may | ||
* differ from the modifiers on the originating element in the source | ||
* language, including {@link Modifier#FINAL final} on a {@linkplain | ||
* Parameter#getModifiers() parameter} and and {@code protected}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and and -> "and"
* | ||
* <p>Besides differences in structural representation between the | ||
* source language and the JVM representation, core reflection also | ||
* exposed runtime specific information. For example, the {@linkplain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposed -> exposes
* explicitly declared ones. | ||
* Returns an array of {@code Type} objects that represent the | ||
* formal parameter types, in declaration order, of the executable | ||
* represented by this object. Returns an array of length 0 if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing subject of the sentence? "This method returns"...
Or "An array of length 0 is returned"...
@jddarcy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036
$ git checkout pull/3036
To update a local copy of the PR:
$ git checkout pull/3036
$ git pull https://git.openjdk.java.net/jdk pull/3036/head