Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262807: Note assumptions of core reflection modeling and parameter handling #3036

Closed
wants to merge 6 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Mar 16, 2021

Please review the javadoc change below, written in response to recent discussion on core-libs.

The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.

I'll update copyright, etc. after agreement on the text is reached.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262807: Note assumptions of core reflection modeling and parameter handling

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036
$ git checkout pull/3036

To update a local copy of the PR:
$ git checkout pull/3036
$ git pull https://git.openjdk.java.net/jdk pull/3036/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Mar 16, 2021
@openjdk openjdk bot added the rfr label Mar 16, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2021

Webrevs

* modifiers present in the {@code class} file representation may
* differ from the modifiers on the originating element in the source
* language, including {@link Modifier#FINAL final} on a {@linkplain
* Parameter#getModifiers() parameter} and and {@code protected},
Copy link
Contributor

@RogerRiggs RogerRiggs Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and and -> "and"

*
* <p>Besides differences in structural representation between the
* source language and the JVM representation, core reflection also
* exposed runtime specific information. For example, the {@linkplain
Copy link
Contributor

@RogerRiggs RogerRiggs Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposed -> exposes

* explicitly declared ones.
* Returns an array of {@code Type} objects that represent the
* formal parameter types, in declaration order, of the executable
* represented by this object. Returns an array of length 0 if the
Copy link
Contributor

@RogerRiggs RogerRiggs Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing subject of the sentence? "This method returns"...
Or "An array of length 0 is returned"...

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

looks good.

@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262807: Note assumptions of core reflection modeling and parameter handling

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Mar 17, 2021

/integrate

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 17, 2021
@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@jddarcy Pushed as commit 99b39aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8262807 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants