Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag #3037

Closed
wants to merge 4 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 16, 2021

The root cause is using the wrong endian, the ICC profile uses big-endian notation. We even have special methods to convert the data, but for some reason, their usage was dropped in the JDK-6523398.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3037/head:pull/3037
$ git checkout pull/3037

To update a local copy of the PR:
$ git checkout pull/3037
$ git pull https://git.openjdk.java.net/jdk pull/3037/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 16, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 16, 2021

@mrserb The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d awt labels Mar 16, 2021
static
void AdjustEndianess32(cmsUInt8Number *pByte)
{
cmsUInt8Number temp1;
Copy link
Member Author

@mrserb mrserb Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic of this method is the same as _cmsAdjustEndianess32 from the "lcms2_plugin.h"

cmsUInt32Number CMSEXPORT _cmsAdjustEndianess32(cmsUInt32Number DWord)

@mrserb
Copy link
Member Author

@mrserb mrserb commented Mar 16, 2021

/label remove awt

@openjdk openjdk bot removed the awt label Mar 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 16, 2021

@mrserb
The awt label was successfully removed.

@mrserb mrserb marked this pull request as ready for review Mar 16, 2021
@openjdk openjdk bot added the rfr label Mar 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 16, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 000012a: 8148937: (str) Adapt StringJoiner for Compact Strings
  • a707fcb: 8263723: [BACKOUT] MoveAndUpdateClosure::do_addr calls function with side-effects in an assert
  • 86e9cd9: 8263667: Avoid running GitHub actions on branches named pr/*
  • 41276eb: 8259863: doc: JShell snippet doesn't compile
  • f9f2eef: 8263434: Dangling references after MethodComparator::methods_EMCP
  • 23fc2a4: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer
  • d1baed6: 8263672: fatal error: no reachable node should have no use
  • 086a66a: 8261095: Add test for clhsdb "symbol" command
  • ec95a5c: 8263410: ListModel javadoc refers to non-existent interface
  • 7b9d256: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/8c1112a690480340bb9d69bfaa463b5619829808...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Mar 18, 2021

/integrate

@openjdk openjdk bot closed this Mar 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@mrserb Since your change was applied there have been 63 commits pushed to the master branch:

  • e34f766: 8252723: Run stack016.java also with C2-only
  • 2173fed: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions
  • 21db0f6: 8263659: Reflow GTestResultParser for better readability
  • e333b6e: 8246494: introduce vm.flagless at-requires property
  • 8c8d1b3: 8263495: Gather liveness info in the mark phase of G1 full gc
  • a85dc55: 8263311: Watch registry changes for remote printers update instead of polling
  • 3f31a6b: 8263775: C2: igv_print() crash unexpectedly when called from debugger
  • 63eae8f: 8260605: Various java.lang.invoke cleanups
  • 9cd21b6: 8263590: Rawtypes warnings should be produced for pattern matching in instanceof
  • ... and 53 more: https://git.openjdk.java.net/jdk/compare/8c1112a690480340bb9d69bfaa463b5619829808...master

Your commit was automatically rebased without conflicts.

Pushed as commit 01ddf3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8263622 branch Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
2 participants