8263725: JFR oldobject tests are not run when GCs are specified explicitly

[stefank]

The tests are tagged with @requires == "null", which has the effect that if you run with GC explicitly set, like:
make -C ../build/fastdebug test TEST=test/jdk/jdk/jfr/event/oldobject/TestZ.java JTREG="JAVA_OPTIONS=-XX:+UseG1GC"

then the tests won't run. The intention has probably been to only run the test with the default GC. I propose that we remove this and run the tests with other GCs as well.

I've tested this locally with ZGC, G1, Parallel and Serial.

The following test doesn't work with ZGC and has been disabled for that GC:
test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java

The following test doesn't work with Serial and has been disabled for that GC
test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263725: JFR oldobject tests are not run when GCs are specified explicitly

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Markus Grönlund (@mgronlun - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3046/head:pull/3046
$ git checkout pull/3046

To update a local copy of the PR:
$ git checkout pull/3046
$ git pull https://git.openjdk.java.net/jdk pull/3046/head

[stefank]

/label jfr

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The label jfr is not a valid label. These labels are valid:

• serviceability
• hotspot
• sound
• hotspot-compiler
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• 2d
• security
• swing
• hotspot-runtime
• jmx
• build
• nio
• beans
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr
• awt

[openjdk]

@stefank The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b0daa54)

[tschatzl]

Lgtm.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263725: JFR oldobject tests are not run when GCs are specified explicitly

Reviewed-by: tschatzl, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• f9f2eef: 8263434: Dangling references after MethodComparator::methods_EMCP
• 23fc2a4: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer
• d1baed6: 8263672: fatal error: no reachable node should have no use
• 086a66a: 8261095: Add test for clhsdb "symbol" command
• ec95a5c: 8263410: ListModel javadoc refers to non-existent interface
• 7b9d256: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
• d2144a5: 8263058: Optimize vector shift with zero shift count
• dd6c911: 8263705: Two shenandoah tests fail due to can't find ClassFileInstaller
• 4acb883: 8261666: [mlvm] Remove WhiteBoxHelper
• 5069796: 8263164: assert(_base >= VectorA && _base <= VectorZ) failed: Not a Vector while calling StoreVectorNode::memory_size()
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/a31a23d5e72c4618b5b67e854ef4909110a1b5b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

Looks good. Thanks.

[stefank]

Thanks for reviewing!
/integrate

[openjdk]

@stefank Since your change was applied there have been 44 commits pushed to the master branch:

• 444a80b: 8263455: NMT: assert on registering a region which completely engulfs an existing region
• 2b93ae0: 8261480: MetaspaceShared::preload_and_dump should check exceptions
• 81ba578: 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()
• 9225a23: 8263108: Class initialization deadlock in java.lang.constant
• 5d5813a: 8263757: Remove serviceability/sa/ClhsdClasses.java from ZGC problem list
• 50ff0d4: 8263756: Fix ZGC ProblemList entry for serviceability/sa/ClhsdbSymbol.java
• 99b39aa: 8262807: Note assumptions of core reflection modeling and parameter handling
• 26234b5: 8254979: Class.getSimpleName() returns non-empty for lambda and method
• 83a49ef: 8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries"
• 24afa36: 8263726: divideToIntegralValue typo on BigDecimal documentation
• ... and 34 more: https://git.openjdk.java.net/jdk/compare/a31a23d5e72c4618b5b67e854ef4909110a1b5b4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 72b82fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.