Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries" #3054

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Mar 17, 2021

These new tests were not adapted to JDK-8263412 changes. The failure is the same as JDK-8263549.

Applied fix from JDK-8263549: "replaces ClassFileInstaller w/ jdk.test.lib.helpers.ClassFileInstaller in failing tests descriptions to ensure we won't get split testlibrary".

Tested tier1, hs-tier2 (where tests failed), running failing tests


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries"

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3054/head:pull/3054
$ git checkout pull/3054

To update a local copy of the PR:
$ git checkout pull/3054
$ git pull https://git.openjdk.java.net/jdk pull/3054/head

…d ClassFileInstaller in test directory or libraries"
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2021
@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 17, 2021
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries"

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 17, 2021
@dcubed-ojdk
Copy link
Member

dcubed-ojdk commented Mar 17, 2021

@vnkozlov - do you know why these new tests weren't exercised before integration?
It seems like they would have failed if they had been run after merging with an up to
date repo...

@mlbridge
Copy link

mlbridge bot commented Mar 17, 2021

Webrevs

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Mar 17, 2021

@vnkozlov - do you know why these new tests weren't exercised before integration?
It seems like they would have failed if they had been run after merging with an up to
date repo...

It is external contribution - they only run tier1.
I tested them up to tier4. But before JDK-8263412 was pushed which broke all tests which references ClassFileInstaller.

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Mar 17, 2021

/integrate

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2021
@openjdk
Copy link

openjdk bot commented Mar 17, 2021

@vnkozlov Pushed as commit 83a49ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8263753 branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants