-
Notifications
You must be signed in to change notification settings - Fork 6k
8263439: getSupportedAttributeValues() throws NPE for Finishings attribute #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
Webrevs
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@@ -569,6 +569,9 @@ public DocPrintJob createPrintJob() { | |||
Finishings[] fAll = (Finishings[]) | |||
(new ExtFinishing(100)).getAll(); | |||
for (int j=0; j<fAll.length; j++) { | |||
if (fAll[j] == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still insisting on copyright's year update?
/integrate |
@prrace Since your change was applied there have been 19 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2173fed. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This seems to be a code path that has has not been exercised.
We need to check for null values in the array.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3055/head:pull/3055
$ git checkout pull/3055
To update a local copy of the PR:
$ git checkout pull/3055
$ git pull https://git.openjdk.java.net/jdk pull/3055/head