Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263439: getSupportedAttributeValues() throws NPE for Finishings attribute #3055

Closed
wants to merge 2 commits into from
Closed

8263439: getSupportedAttributeValues() throws NPE for Finishings attribute #3055

wants to merge 2 commits into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Mar 17, 2021

This seems to be a code path that has has not been exercised.
We need to check for null values in the array.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3055/head:pull/3055
$ git checkout pull/3055

To update a local copy of the PR:
$ git checkout pull/3055
$ git pull https://git.openjdk.java.net/jdk pull/3055/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@prrace The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Mar 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Reviewed-by: psadhukhan, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 21db0f6: 8263659: Reflow GTestResultParser for better readability
  • e333b6e: 8246494: introduce vm.flagless at-requires property
  • 8c8d1b3: 8263495: Gather liveness info in the mark phase of G1 full gc
  • a85dc55: 8263311: Watch registry changes for remote printers update instead of polling
  • 3f31a6b: 8263775: C2: igv_print() crash unexpectedly when called from debugger
  • 63eae8f: 8260605: Various java.lang.invoke cleanups
  • 9cd21b6: 8263590: Rawtypes warnings should be produced for pattern matching in instanceof
  • ff52f29: 8260716: Assert in MacroAssembler::clear_mem with -XX:-IdealizeClearArrayNode
  • 72b82fd: 8263725: JFR oldobject tests are not run when GCs are specified explicitly
  • 444a80b: 8263455: NMT: assert on registering a region which completely engulfs an existing region
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/24afa36d5c870b4f790ca2753107e12597e7262d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 18, 2021
@@ -569,6 +569,9 @@ public DocPrintJob createPrintJob() {
Finishings[] fAll = (Finishings[])
(new ExtFinishing(100)).getAll();
for (int j=0; j<fAll.length; j++) {
if (fAll[j] == null) {
Copy link
Member

@azvegint azvegint Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still insisting on copyright's year update?

@prrace
Copy link
Contributor Author

@prrace prrace commented Mar 18, 2021

/integrate

@openjdk openjdk bot closed this Mar 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@prrace Since your change was applied there have been 19 commits pushed to the master branch:

  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions
  • 21db0f6: 8263659: Reflow GTestResultParser for better readability
  • e333b6e: 8246494: introduce vm.flagless at-requires property
  • 8c8d1b3: 8263495: Gather liveness info in the mark phase of G1 full gc
  • a85dc55: 8263311: Watch registry changes for remote printers update instead of polling
  • 3f31a6b: 8263775: C2: igv_print() crash unexpectedly when called from debugger
  • 63eae8f: 8260605: Various java.lang.invoke cleanups
  • 9cd21b6: 8263590: Rawtypes warnings should be produced for pattern matching in instanceof
  • ff52f29: 8260716: Assert in MacroAssembler::clear_mem with -XX:-IdealizeClearArrayNode
  • 72b82fd: 8263725: JFR oldobject tests are not run when GCs are specified explicitly
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/24afa36d5c870b4f790ca2753107e12597e7262d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2173fed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the finishings branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants