Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263756: Fix ZGC ProblemList entry for serviceability/sa/ClhsdbSymbol.java #3056

Closed
wants to merge 1 commit into from

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Mar 17, 2021

I'd like to push this as a trivial change. serviceability/sa/ClhsdbSymbol.java was problem listed with the wrong CR. This PR will correct that and also put the entry in sorted order.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263756: Fix ZGC ProblemList entry for serviceability/sa/ClhsdbSymbol.java

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3056/head:pull/3056
$ git checkout pull/3056

To update a local copy of the PR:
$ git checkout pull/3056
$ git pull https://git.openjdk.java.net/jdk pull/3056/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Mar 17, 2021

/label serviceability

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@plummercj
The serviceability label was successfully added.

Loading

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Mar 17, 2021

/label hotspot-gc

Loading

@openjdk openjdk bot added the hotspot-gc label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@plummercj
The hotspot-gc label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

Loading

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

I agree that this is a trivial change.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263756: Fix ZGC ProblemList entry for serviceability/sa/ClhsdbSymbol.java

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 83a49ef: 8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 17, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Mar 17, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@plummercj Since your change was applied there have been 3 commits pushed to the master branch:

  • 99b39aa: 8262807: Note assumptions of core reflection modeling and parameter handling
  • 26234b5: 8254979: Class.getSimpleName() returns non-empty for lambda and method
  • 83a49ef: 8263753: two new tests from JDK-8261671 fail with "Error. can not find ClassFileInstaller in test directory or libraries"

Your commit was automatically rebased without conflicts.

Pushed as commit 50ff0d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@plummercj plummercj deleted the 8263730-pb_symbol branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants