Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)" #3060

Closed
wants to merge 1 commit into from

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Mar 17, 2021

The test requests NotifyFrame event from MethodEntry handler expecting that 1st MethodEntry event is generated for main thread.
The fix adds a check that the thread is correct and skips event from other threads


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3060/head:pull/3060
$ git checkout pull/3060

To update a local copy of the PR:
$ git checkout pull/3060
$ git pull https://git.openjdk.java.net/jdk pull/3060/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

The fix is good. Might be it is needed to comment why the SetEventNotification on a single thread is not used.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Mar 18, 2021

Might be it is needed to comment why the SetEventNotification on a single thread is not used.

I think this is what the test about. Description says:
Profiling agent setnotif001.c enables globally events
...
and checks if all they are sent after been enabled and are not
sent before that.

Copy link
Contributor

@plummercj plummercj left a comment

Changes look good. Don't know why git.diff butchered what should have been a very simple to read diff so much.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"

Reviewed-by: lmesnik, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

  • c82a673: 8262001: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java failed with "RuntimeException: Current Peak = 14 Expected to be == previous peak = 7 + 8"
  • 01ddf3d: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag
  • e34f766: 8252723: Run stack016.java also with C2-only
  • 2173fed: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions
  • 21db0f6: 8263659: Reflow GTestResultParser for better readability
  • e333b6e: 8246494: introduce vm.flagless at-requires property
  • 8c8d1b3: 8263495: Gather liveness info in the mark phase of G1 full gc
  • a85dc55: 8263311: Watch registry changes for remote printers update instead of polling
  • 3f31a6b: 8263775: C2: igv_print() crash unexpectedly when called from debugger
  • ... and 153 more: https://git.openjdk.java.net/jdk/compare/eb4a8af559cae9374d29617053a1113ac4b7de2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 18, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Mar 19, 2021

/integrate

@openjdk openjdk bot closed this Mar 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@alexmenkov Since your change was applied there have been 182 commits pushed to the master branch:

  • 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
  • 0b5216a: 8263545: Convert jpackage to use Stream.toList()
  • ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
  • 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
  • d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp
  • b49c589: 8263658: Use the blessed modifier order in java.base
  • 1572f3c: 8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs
  • 57497ab: 8263821: Remove unused MethodTypeForm canonicalization codes
  • 4d51a82: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c
  • 701fd9d: 8262476: Add filter to speed up CompileCommand lookup
  • ... and 172 more: https://git.openjdk.java.net/jdk/compare/eb4a8af559cae9374d29617053a1113ac4b7de2e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6737135.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the NotifyPopFrame branch Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants