8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines #3062
All JRT_ENTRY routines are required to have a parameter, "JavaThread* thread", which must be the current thread. The JRT_ENTRY, and related macros, then use this parameter and also expose it as THREAD for use with exception macros. But the fact "thread" is the current thread is lost in some routines and we see strange calls to other code that pass both "thread" and "THREAD" as distinct parameters - primarily when a TRAPS method is involved.
This should be cleaned up along with a general check on misuse of TRAPS/THREAD.
Testing: tiers 1-3
To checkout this PR locally:
To update a local copy of the PR:
coleenp left a comment
Can you state the convention that you're trying to establish?
On 19/03/2021 10:00 pm, Coleen Phillimore wrote:
That is the endgame for JDK-8252685. The current issue is a step along
and in all cases they then declare an alias:
Thread* THREAD = thread;
for use with TRAPS/CHECK