Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263776: [JVMCI] add helper to perform Java upcalls #3067

Closed
wants to merge 2 commits into from

Conversation

@tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Mar 18, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263776: [JVMCI] add helper to perform Java upcalls

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3067/head:pull/3067
$ git checkout pull/3067

To update a local copy of the PR:
$ git checkout pull/3067
$ git pull https://git.openjdk.java.net/jdk pull/3067/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@tkrodriguez The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2021

Webrevs

src/hotspot/share/jvmci/jvmciRuntime.cpp Outdated Show resolved Hide resolved
src/hotspot/share/jvmci/jvmciRuntime.cpp Outdated Show resolved Hide resolved
src/hotspot/share/jvmci/jvmciRuntime.cpp Outdated Show resolved Hide resolved
@tkrodriguez tkrodriguez force-pushed the stub-invoke-helper branch from d24bd0d to 0a3b1bf Mar 18, 2021
@tkrodriguez
Copy link
Contributor Author

@tkrodriguez tkrodriguez commented Mar 18, 2021

I had pushed the wrong version of this in the initial commit but it's now the correct one. There were changes to SignatureIterator that needs accommodation and I'd pushed an older version of this fix.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

Please, run at least tier1 mach5 testing before push.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263776: [JVMCI] add helper to perform Java upcalls

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • 6aa28b3: 8263827: Suspend "missing" javadoc doclint checks for smartcardio
  • ed1e25d: 8263833: Stop disabling warnings for sunFont.c with gcc
  • 788e30c: 8263320: [test] Add Object Stream Formatter to work with test utility HexPrinter
  • fa0f161: 8263742: (bf) MappedByteBuffer.force() should use the capacity as its upper bound
  • c82a673: 8262001: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java failed with "RuntimeException: Current Peak = 14 Expected to be == previous peak = 7 + 8"
  • 01ddf3d: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag
  • e34f766: 8252723: Run stack016.java also with C2-only
  • 2173fed: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/5d5813a5d35c0b7e989ccc7a826173376c4cdb17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 18, 2021
@dougxc
Copy link
Member

@dougxc dougxc commented Mar 22, 2021

Looks good to me.

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Mar 22, 2021

Thank you, for running tests.

@tkrodriguez
Copy link
Contributor Author

@tkrodriguez tkrodriguez commented Mar 23, 2021

/integrate

@openjdk openjdk bot closed this Mar 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@tkrodriguez Since your change was applied there have been 65 commits pushed to the master branch:

  • b23228d: 8263914: CDS fails to find the default shared archive on x86_32
  • a5e7a89: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32
  • f62b100: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices
  • f84b52b: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • f08bf4b: 8263891: Changes for 8076985 missed the fix.
  • b2df513: 8261785: Calling "main" method in anonymous nested class crashes the JVM
  • 840ab7b: 8263894: Convert defaultPrinter and printers fields to local variables
  • ba504fc: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll
  • 0abbfb2: 8263729: [test] divert spurious output away from stream under test in ProcessBuilder Basic test
  • 6c2220e: 8263861: Shenandoah: Remove unused member in ShenandoahGCStateResetter
  • ... and 55 more: https://git.openjdk.java.net/jdk/compare/5d5813a5d35c0b7e989ccc7a826173376c4cdb17...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6b4c654.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants