8258753: StartTlsResponse.close() hangs due to synchronization issues

[pkumaraswamy]

Scenario:

1. Issue occurs in a muti-threaded environment where SSL socket read() and close() are invoked in parallel.
2. SSL socket read is already called.
3. close() calls waitForCloseNotify() -> decode() ->....-> socketRead0() to read the close_notify acknowledgment.
4. Since there is no synchronization between these read operations, the thread which had already invoked read(), reads the close_notify acknowledgment.
5. The thread (which calls waitForCloseNotify() -> read() ) waits indefinitely in socketRead0() and hangs.
6. Reproduced and tested the fix against a real time MS AD LDAP server.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3068/head:pull/3068
$ git checkout pull/3068

To update a local copy of the PR:
$ git checkout pull/3068
$ git pull https://git.openjdk.java.net/jdk pull/3068/head

[bridgekeeper]

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pkumaraswamy The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0e11b8f)

[openjdk]

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 126 new commits pushed to the master branch:

• 3e18330: 8264018: AArch64: NEON loadV2 and storeV2 addressing is wrong
• 0ff8168: 8258957: DocLint: check for HTML start element at end of body
• 3d7f912: 8220266: add support for additional metadata in add/remove programs
• 37f494c: 8260619: Add final modifier to several DataFlavor static fields
• cfc9aa3: 8264002: Delete outdated assumptions about ColorSpace initialization
• 623f0b6: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
• 1a13c9e: 8263473: Update annotation terminology (2)
• 3e751a5: 8263198: javadoc HELP page
• 5ca5962: 8259926: Error in jpackage sample usage in the help text
• 70d3401: 8263887: Re-create default icons
• ... and 116 more: https://git.openjdk.java.net/jdk/compare/81ba5784ba866be39612982c637b509c8205e88f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[pkumaraswamy]

/integrate

[openjdk]

@pkumaraswamy
Your change (at version 0e11b8f) is now ready to be sponsored by a Committer.

[XueleiFan]

/sponsor

[openjdk]

@XueleiFan @pkumaraswamy Since your change was applied there have been 126 commits pushed to the master branch:

• 3e18330: 8264018: AArch64: NEON loadV2 and storeV2 addressing is wrong
• 0ff8168: 8258957: DocLint: check for HTML start element at end of body
• 3d7f912: 8220266: add support for additional metadata in add/remove programs
• 37f494c: 8260619: Add final modifier to several DataFlavor static fields
• cfc9aa3: 8264002: Delete outdated assumptions about ColorSpace initialization
• 623f0b6: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
• 1a13c9e: 8263473: Update annotation terminology (2)
• 3e751a5: 8263198: javadoc HELP page
• 5ca5962: 8259926: Error in jpackage sample usage in the help text
• 70d3401: 8263887: Re-create default icons
• ... and 116 more: https://git.openjdk.java.net/jdk/compare/81ba5784ba866be39612982c637b509c8205e88f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4155533.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.