Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258753: StartTlsResponse.close() hangs due to synchronization issues #3068

Closed
wants to merge 1 commit into from
Closed

8258753: StartTlsResponse.close() hangs due to synchronization issues #3068

wants to merge 1 commit into from

Conversation

pkumaraswamy
Copy link
Contributor

@pkumaraswamy pkumaraswamy commented Mar 18, 2021

Scenario:

  1. Issue occurs in a muti-threaded environment where SSL socket read() and close() are invoked in parallel.
  2. SSL socket read is already called.
  3. close() calls waitForCloseNotify() -> decode() ->....-> socketRead0() to read the close_notify acknowledgment.
  4. Since there is no synchronization between these read operations, the thread which had already invoked read(), reads the close_notify acknowledgment.
  5. The thread (which calls waitForCloseNotify() -> read() ) waits indefinitely in socketRead0() and hangs.
  6. Reproduced and tested the fix against a real time MS AD LDAP server.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3068/head:pull/3068
$ git checkout pull/3068

To update a local copy of the PR:
$ git checkout pull/3068
$ git pull https://git.openjdk.java.net/jdk pull/3068/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2021

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2021
@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@pkumaraswamy The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 18, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 24, 2021

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258753: StartTlsResponse.close() hangs due to synchronization issues

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 126 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2021
@pkumaraswamy
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@pkumaraswamy
Your change (at version 0e11b8f) is now ready to be sponsored by a Committer.

@XueleiFan
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Mar 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@XueleiFan @pkumaraswamy Since your change was applied there have been 126 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4155533.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants