Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253493: Shenandoah: Remove ShenandoahSerialRoot definition #307

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Sep 22, 2020

JDK-8247281 removed ShenandoahSerialRoot's implementation and uses, but not its definition.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253493: Shenandoah: Remove ShenandoahSerialRoot definition

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/307/head:pull/307
$ git checkout pull/307

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2020
@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@zhengyu123 The following labels will be automatically applied to this pull request: hotspot-gc shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Sep 22, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2020

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@zhengyu123 This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253493: Shenandoah: Remove ShenandoahSerialRoot definition

Reviewed-by: rkennke
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
  • 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7b860120e130c13de8ba543a8706c9ecdeab468b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2020
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2020
@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@zhengyu123 Since your change was applied there have been 4 commits pushed to the master branch:

  • 7b86012: 8253492: Miss comma after second copyright year in FDBigInteger.java
  • 0f26ab1: 8252518: cache result of CompilerToVM.getComponentType
  • c1df13b: 8253208: Move CDS related code to a separate class
  • 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…

Your commit was automatically rebased without conflicts.

Pushed as commit 581f0f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8253493 branch September 22, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants