Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263825: Remove unused and commented out member from NTLMException #3076

Closed
wants to merge 1 commit into from

Conversation

@alblue
Copy link
Contributor

@alblue alblue commented Mar 18, 2021

Removed commented out value from NTLMException


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263825: Remove unused and commented out member from NTLMException

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3076/head:pull/3076
$ git checkout pull/3076

To update a local copy of the PR:
$ git checkout pull/3076
$ git pull https://git.openjdk.java.net/jdk pull/3076/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 18, 2021

See commentary on #2993

@alblue alblue mentioned this pull request Mar 18, 2021
3 of 3 tasks complete
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@alblue The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Mar 18, 2021
@cl4es
Copy link
Member

@cl4es cl4es commented Mar 18, 2021

Filed JDK-8263825 for this.

@alblue alblue force-pushed the alblue:Cleanup-RemoveUnused branch from f146819 to 7a06af9 Mar 18, 2021
@alblue alblue changed the title Remove unused and commented out member from NTLMException 8263825: Remove unused and commented out member from NTLMException Mar 18, 2021
@openjdk openjdk bot added the rfr label Mar 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2021

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Seems fine to me. You should assign yourself to https://bugs.openjdk.java.net/browse/JDK-8263825.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263825: Remove unused and commented out member from NTLMException

Reviewed-by: mullan, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • b49c589: 8263658: Use the blessed modifier order in java.base
  • 1572f3c: 8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs
  • 57497ab: 8263821: Remove unused MethodTypeForm canonicalization codes
  • 4d51a82: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c
  • 701fd9d: 8262476: Add filter to speed up CompileCommand lookup
  • 454af87: 8263185: Mallinfo deprecated in glibc 2.33
  • d24e4cf: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale
  • 1a21f77: 8263482: Make access to the ICC color profiles data multithread-friendly
  • d185655: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task
  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/f9f2eef91ddcff5b5d113577a6c7e520875e77e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan, @cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 19, 2021
@cl4es
Copy link
Member

@cl4es cl4es commented Mar 19, 2021

I don't think Alex has a JBS user yet, so I'll assign the bugs I file on his behalf to me to get it off any dashboards.

@cl4es
cl4es approved these changes Mar 19, 2021
@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 19, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@alblue
Your change (at version 7a06af9) is now ready to be sponsored by a Committer.

@cl4es
Copy link
Member

@cl4es cl4es commented Mar 19, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@cl4es @alblue Since your change was applied there have been 56 commits pushed to the master branch:

  • 77ebc11: 8263892: More modifier order fixes in java.base
  • 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
  • 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
  • 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
  • 0b5216a: 8263545: Convert jpackage to use Stream.toList()
  • ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
  • 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
  • d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp
  • b49c589: 8263658: Use the blessed modifier order in java.base
  • 1572f3c: 8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs
  • ... and 46 more: https://git.openjdk.java.net/jdk/compare/f9f2eef91ddcff5b5d113577a6c7e520875e77e1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6fa6557.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alblue alblue deleted the alblue:Cleanup-RemoveUnused branch Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants