Skip to content

Conversation

@bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented Mar 18, 2021

Build change only. This is to prevent javadoc build failures in java.smartcardio when "missing" is eventually removed from the doclint exclude target list.

This is a follow-on to JDK-8252833, which is a subtask of JDK-8251202.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263827: Suspend "missing" javadoc doclint checks for smartcardio

Reviewers

Contributors

  • Magnus Ihse Bursie <ihse@openjdk.org>

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3079/head:pull/3079
$ git checkout pull/3079

To update a local copy of the PR:
$ git checkout pull/3079
$ git pull https://git.openjdk.java.net/jdk pull/3079/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2021

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@bradfordwetmore The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 18, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263827: Suspend "missing" javadoc doclint checks for smartcardio

Co-authored-by: Magnus Ihse Bursie <ihse@openjdk.org>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • ed1e25d: 8263833: Stop disabling warnings for sunFont.c with gcc
  • 788e30c: 8263320: [test] Add Object Stream Formatter to work with test utility HexPrinter
  • fa0f161: 8263742: (bf) MappedByteBuffer.force() should use the capacity as its upper bound
  • c82a673: 8262001: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java failed with "RuntimeException: Current Peak = 14 Expected to be == previous peak = 7 + 8"
  • 01ddf3d: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag
  • e34f766: 8252723: Run stack016.java also with C2-only
  • 2173fed: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2021
@bradfordwetmore
Copy link
Contributor Author

/contributor add ihse

@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@bradfordwetmore
Contributor Magnus Ihse Bursie <ihse@openjdk.org> successfully added.

@bradfordwetmore
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2021
@openjdk
Copy link

openjdk bot commented Mar 18, 2021

@bradfordwetmore Since your change was applied there have been 8 commits pushed to the master branch:

  • ed1e25d: 8263833: Stop disabling warnings for sunFont.c with gcc
  • 788e30c: 8263320: [test] Add Object Stream Formatter to work with test utility HexPrinter
  • fa0f161: 8263742: (bf) MappedByteBuffer.force() should use the capacity as its upper bound
  • c82a673: 8262001: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java failed with "RuntimeException: Current Peak = 14 Expected to be == previous peak = 7 + 8"
  • 01ddf3d: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag
  • e34f766: 8252723: Run stack016.java also with C2-only
  • 2173fed: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute
  • e543a50: 8261352: Create implementation for component peer for all the components who should be ignored in a11y interactions

Your commit was automatically rebased without conflicts.

Pushed as commit 6aa28b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bradfordwetmore bradfordwetmore deleted the JDK-8263827 branch March 18, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants