Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247370: Clean up unused printing code in awt_PrintJob.cpp #3083

Closed
wants to merge 1 commit into from
Closed

8247370: Clean up unused printing code in awt_PrintJob.cpp #3083

wants to merge 1 commit into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Mar 18, 2021

This removes a long time un-used code path.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247370: Clean up unused printing code in awt_PrintJob.cpp

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3083/head:pull/3083
$ git checkout pull/3083

To update a local copy of the PR:
$ git checkout pull/3083
$ git pull https://git.openjdk.java.net/jdk pull/3083/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@prrace The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2021

Webrevs

Loading

mrserb
mrserb approved these changes Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8247370: Clean up unused printing code in awt_PrintJob.cpp

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d24e4cf: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale
  • 1a21f77: 8263482: Make access to the ICC color profiles data multithread-friendly
  • d185655: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task
  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • 6aa28b3: 8263827: Suspend "missing" javadoc doclint checks for smartcardio

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 19, 2021
Copy link
Contributor

@prsadhuk prsadhuk left a comment

Maybe we should put noreg-cleanup in JBS.

Loading

@prrace
Copy link
Contributor Author

@prrace prrace commented Mar 19, 2021

/integrate

Loading

@prrace
Copy link
Contributor Author

@prrace prrace commented Mar 19, 2021

Maybe we should put noreg-cleanup in JBS.

done

Loading

@openjdk openjdk bot closed this Mar 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@prrace Since your change was applied there have been 11 commits pushed to the master branch:

  • b49c589: 8263658: Use the blessed modifier order in java.base
  • 1572f3c: 8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs
  • 57497ab: 8263821: Remove unused MethodTypeForm canonicalization codes
  • 4d51a82: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c
  • 701fd9d: 8262476: Add filter to speed up CompileCommand lookup
  • 454af87: 8263185: Mallinfo deprecated in glibc 2.33
  • d24e4cf: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale
  • 1a21f77: 8263482: Make access to the ICC color profiles data multithread-friendly
  • d185655: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task
  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/ed1e25d548d66b26b68489b7feae920fa66c879c...master

Your commit was automatically rebased without conflicts.

Pushed as commit d41f751.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@prrace prrace deleted the print_dib branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants