8382582: Remove the experimental JVMCI feature by mhaessig · Pull Request #30834 · openjdk/jdk

mhaessig · 2026-04-21T08:05:02Z

This PR removes the experimental JVMCI feature and all usages and references of it, including references to Graal. For more details on the rationale, please see the issue description.

This change was constructed in several steps:

Remove all folders directly related to JVMCI.
Go through one folder at a time and remove code relating to matches for the regex ([Jj][Vv][Mm][Cc][Ii])|([Gg]raal)|vm\.ci|[Gg]alahad and immediately obvious dead code.
Filter the git blame for each file for JVMCI related commits and check if that code is now dead.

Note to Reviewers

Each commit is limited to a subfolder or a change spanning further so you can take look at a piece of the codebase you are familiar with. I recommend you look at individual commits and select "Ignore Whitespace" in the Github UI.

Testing

Github Actions
tier1-6 linux-x64, linux-aarch64, windows-x64, macosx-aarch64, macosx-x64
build linux-zero, linux-arm, linux-riscv, linux-ppc (LE & BE) fastdebug with features C1+C2, C2 only, C1 only

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8385105 to be approved
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

JDK-8382582: Remove the experimental JVMCI feature (Enhancement - P4)
JDK-8385105: Remove the experimental JVMCI feature (CSR)

Reviewers

Chen Liang (@liach - Reviewer)
Stefan Karlsson (@stefank - Reviewer) Review applies to 3ab2183a
Coleen Phillimore (@coleenp - Reviewer) Review applies to 3f822c8f
Erik Joelsson (@erikj79 - Reviewer) Review applies to 0100264f
Vladimir Kozlov (@vnkozlov - Reviewer)
Vladimir Ivanov (@iwanowww - Reviewer) Review applies to 3f822c8f
Chris Plummer (@plummercj - Reviewer) Review applies to 3f822c8f
Alan Bateman (@AlanBateman - Reviewer) Review applies to 3f822c8f

Contributors

Tobias Hartmann <thartmann@openjdk.org>
Mikael Vidstedt <mikael@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30834/head:pull/30834
$ git checkout pull/30834

Update a local copy of the PR:
$ git checkout pull/30834
$ git pull https://git.openjdk.org/jdk.git pull/30834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30834

View PR using the GUI difftool:
$ git pr show -t 30834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30834.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-04-21T08:06:20Z

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mhaessig · 2026-04-21T08:06:59Z

/contributor add @TobiHartmann
/contributor add @vidmik

openjdk · 2026-04-21T08:07:47Z

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382582: Remove the experimental JVMCI feature

Co-authored-by: Tobias Hartmann <thartmann@openjdk.org>
Co-authored-by: Mikael Vidstedt <mikael@openjdk.org>
Reviewed-by: liach, kvn, stefank, coleenp, erikj, vlivanov, cjplummer, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

3a9cb9a: 8385092: KeyChainStore entry creation time is always now
56b2dcf: 8385165: [ubsan] TestDockerMemoryMetricsSubgroup.java jtreg test fails with ubsan-enabled binaries
20c590f: 8383186: Large SoftRefLRUPolicyMSPerMB can lead to overflow
... and 3 more: https://git.openjdk.org/jdk/compare/94d3aecfed043f0e8825922a17ef1d50e6bc86f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-04-21T08:08:46Z

@mhaessig
Contributor Tobias Hartmann <thartmann@openjdk.org> successfully added.

openjdk · 2026-04-21T08:09:45Z

@mhaessig
Contributor Mikael Vidstedt <mikael@openjdk.org> successfully added.

openjdk · 2026-04-21T08:11:08Z

@mhaessig The following labels will be automatically applied to this pull request:

build
compiler
core-libs
hotspot
ide-support
javadoc
net
nio
security
serviceability
shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

openjdk · 2026-04-21T08:11:13Z

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

liach

Core library changes look fine.

wangweij · 2026-04-23T15:36:25Z

/label remove security

openjdk · 2026-04-23T15:37:53Z

@wangweij
The security label was successfully removed.

openjdk · 2026-04-23T15:38:30Z

@mhaessig this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-jvmci
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Co-Authored-By: Vladimir Ivanov <vladimir.x.ivanov@oracle.com>

mhaessig

Thank you all for reviewing. I addressed all of your comments in the new commits and I merged master.

mhaessig · 2026-05-18T11:24:23Z

@@ -1771,28 +1765,18 @@ class vector_VectorPayload : AllStatic {
 };

 class java_lang_Integer : AllStatic {


Removed in cf16786. I think those are the ones you meant?

plummercj

SA changes look good.

AlanBateman

All good, I don't have any other questions/comments.

vnkozlov

Good.

liach

Core libs and javadoc changes look trivially fine.

liach · 2026-05-18T17:01:12Z

I don't know if we want to remove this file or do the jdk.jsobject-style removal in the symbols - it might be okay for us to nuke these internal modules this way.

Hmm.

I think removing the files for JDK releases from "M" (i.e. 22) through "R" (i.e. 27) i needs some more consideration, Removing the files in the current release is much less problematic.

/csr needed

Sorry, I somehow missed this. Normally, I would say the historical data (i.e. src/jdk.compiler/share/data/symbols) should not be touched when removing something. But, in this case, these files seem more like an accident than real history. They are not used (not used in symbols), and so are not part of ct.sym, and so do not affect --release. It is possible the script malfunctioned when producing the historical record for JDK 22, as there are a few more files like this for JDK 22 (jdk.internal.ed-M.sym.txt, jdk.internal.jvmstat-M.sym.txt, jdk.internal.le-M.sym.txt, jdk.internal.opt-M.sym.txt).

So, I am fine with removing JVMCI-related files. Separately, we might look at cleaning up the other stray JDK 22 files and/or investigating what happened.

Thank you for the analysis @lahodaj .

coleenp

The classfile code looks good. Thanks for the extra cleanup.

jddarcy · 2026-05-19T00:10:03Z

/csr needed

openjdk · 2026-05-19T00:12:23Z

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mhaessig please create a CSR request for issue JDK-8382582 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

vnkozlov · 2026-05-19T17:00:50Z

I don't know if we want to remove this file or do the jdk.jsobject-style removal in the symbols - it might be okay for us to nuke these internal modules this way.

I think removing the files for JDK releases from "M" (i.e. 22) through "R" (i.e. 27) i needs some more consideration, Removing the files in the current release is much less problematic.

Note, JVMCI was always JDK internal experimental feature. javac --release applies to public Java API

I am not sure what the goal of CSR will be here.

vnkozlov · 2026-05-20T17:08:45Z

CSR: https://bugs.openjdk.org/browse/JDK-8385105

liach

Removal of the javac symbol files should be fine. javac's --add-modules already does not work with --release for these removed modules.

vnkozlov

Good.

dev-jonghoonpark · 2026-05-23T07:39:16Z

mhaessig force-pushed the remove-jvmci branch from a6887c2 to a240b4e Compare April 21, 2026 08:13

mhaessig commented Apr 21, 2026

View reviewed changes

Comment thread src/jdk.jfr/share/classes/jdk/jfr/internal/TypeLibrary.java

mhaessig force-pushed the remove-jvmci branch from a240b4e to 0391bb0 Compare April 22, 2026 06:48

liach reviewed Apr 22, 2026

View reviewed changes

Comment thread src/java.base/share/classes/jdk/internal/vm/VMSupport.java

openjdk Bot removed the security security-dev@openjdk.org label Apr 23, 2026

openjdk Bot added the merge-conflict Pull request has merge conflict with target branch label Apr 23, 2026

mhaessig force-pushed the remove-jvmci branch from 0391bb0 to 900b060 Compare April 24, 2026 11:47

openjdk Bot added security security-dev@openjdk.org and removed merge-conflict Pull request has merge conflict with target branch labels Apr 24, 2026

mhaessig and others added 4 commits May 18, 2026 11:08

More dead code

35b2f1a

Co-Authored-By: Vladimir Ivanov <vladimir.x.ivanov@oracle.com>

Remove unused boxed primitive classes

cf16786

serviceablity: remove CompilerTread.java

640de4f

Merge branch 'master' into remove-jvmci

dfea1e5

mhaessig commented May 18, 2026

View reviewed changes

openjdk Bot removed the ready Pull request is ready to be integrated label May 18, 2026

Copyright years

2cf8016

plummercj approved these changes May 18, 2026

View reviewed changes

AlanBateman approved these changes May 18, 2026

View reviewed changes

vnkozlov approved these changes May 18, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label May 18, 2026

liach reviewed May 18, 2026

View reviewed changes

iwanowww approved these changes May 18, 2026

View reviewed changes

coleenp approved these changes May 18, 2026

View reviewed changes

openjdk Bot added the csr Pull request needs approved CSR before integration label May 19, 2026

openjdk Bot removed the ready Pull request is ready to be integrated label May 19, 2026

Merge branch 'master' into remove-jvmci

3f822c8

mhaessig added 2 commits May 20, 2026 09:57

Merge branch 'master' into remove-jvmci

895df8a

Merge branch 'master' into remove-jvmci

1a95e79

liach approved these changes May 20, 2026

View reviewed changes

mhaessig added 2 commits May 21, 2026 10:43

Merge branch 'master' into remove-jvmci

d780b13

Merge branch 'master' into remove-jvmci

124e882

openjdk Bot removed the csr Pull request needs approved CSR before integration label May 22, 2026

vnkozlov approved these changes May 22, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label May 22, 2026

dev-jonghoonpark reviewed May 23, 2026

View reviewed changes

		@@ -1771,28 +1765,18 @@ class vector_VectorPayload : AllStatic {
		};

		class java_lang_Integer : AllStatic {


	* Copyright (c) 2007, 2026, Oracle and/or its affiliates. All rights reserved.

Conversation

mhaessig commented Apr 21, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note to Reviewers

Testing

Progress

Issues

Reviewers

Contributors

Reviewing

Uh oh!

bridgekeeper Bot commented Apr 21, 2026

Uh oh!

mhaessig commented Apr 21, 2026

Uh oh!

openjdk Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Apr 21, 2026

Uh oh!

openjdk Bot commented Apr 21, 2026

Uh oh!

openjdk Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Apr 21, 2026

Uh oh!

Uh oh!

liach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wangweij commented Apr 23, 2026

Uh oh!

openjdk Bot commented Apr 23, 2026

Uh oh!

openjdk Bot commented Apr 23, 2026

Uh oh!

mhaessig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhaessig May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plummercj left a comment

Choose a reason for hiding this comment

Uh oh!

AlanBateman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

liach left a comment

Choose a reason for hiding this comment

Uh oh!

liach May 18, 2026

Choose a reason for hiding this comment

Uh oh!

jddarcy May 18, 2026

Choose a reason for hiding this comment

Uh oh!

jddarcy May 18, 2026

Choose a reason for hiding this comment

Uh oh!

lahodaj May 22, 2026

Choose a reason for hiding this comment

Uh oh!

jddarcy May 22, 2026

Choose a reason for hiding this comment

Uh oh!

mhaessig commented Apr 21, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Apr 21, 2026 •

edited

Loading

openjdk Bot commented Apr 21, 2026 •

edited

Loading

AlanBateman left a comment •

edited

Loading