Skip to content

8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 19, 2021

Trivial change of removing an unused method.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3085/head:pull/3085
$ git checkout pull/3085

To update a local copy of the PR:
$ git checkout pull/3085
$ git pull https://git.openjdk.java.net/jdk pull/3085/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2021
@openjdk
Copy link

openjdk bot commented Mar 19, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 19, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented Mar 19, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263852: Unused method SoftRefPolicy::use_should_clear_all_soft_refs

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 701fd9d: 8262476: Add filter to speed up CompileCommand lookup
  • 454af87: 8263185: Mallinfo deprecated in glibc 2.33
  • d24e4cf: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale
  • 1a21f77: 8263482: Make access to the ICC color profiles data multithread-friendly
  • d185655: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task
  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • 6aa28b3: 8263827: Suspend "missing" javadoc doclint checks for smartcardio
  • ed1e25d: 8263833: Stop disabling warnings for sunFont.c with gcc
  • 788e30c: 8263320: [test] Add Object Stream Formatter to work with test utility HexPrinter
  • fa0f161: 8263742: (bf) MappedByteBuffer.force() should use the capacity as its upper bound
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/8c8d1b31f0cb8a1af3a5f6e9a8c7e4c9268f4bfb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 19, 2021
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk openjdk bot closed this Mar 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2021
@openjdk
Copy link

openjdk bot commented Mar 19, 2021

@albertnetymk Since your change was applied there have been 19 commits pushed to the master branch:

  • 57497ab: 8263821: Remove unused MethodTypeForm canonicalization codes
  • 4d51a82: 8263818: Release JNI local references in get/set-InetXXAddress-member helper functions of net_util.c
  • 701fd9d: 8262476: Add filter to speed up CompileCommand lookup
  • 454af87: 8263185: Mallinfo deprecated in glibc 2.33
  • d24e4cf: 8263481: Specification of JComponent::setDefaultLocale doesn't mention that passing 'null' restores VM's default locale
  • 1a21f77: 8263482: Make access to the ICC color profiles data multithread-friendly
  • d185655: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task
  • 434a399: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • 6aa28b3: 8263827: Suspend "missing" javadoc doclint checks for smartcardio
  • ed1e25d: 8263833: Stop disabling warnings for sunFont.c with gcc
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/8c8d1b31f0cb8a1af3a5f6e9a8c7e4c9268f4bfb...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1572f3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the soft branch March 19, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants