Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264019: Use the blessed modifier order in java.xml #3091

Closed
wants to merge 2 commits into from

Conversation

@alblue
Copy link
Contributor

@alblue alblue commented Mar 19, 2021

As a subtask of JDK-8263854 this cleans up the java.xml module to used the blessed modifier order.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264019: Use the blessed modifier order in java.xml

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3091/head:pull/3091
$ git checkout pull/3091

To update a local copy of the PR:
$ git checkout pull/3091
$ git pull https://git.openjdk.java.net/jdk pull/3091/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 19, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@alblue The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Mar 19, 2021
@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 19, 2021

Would someone mind creating a bug for me under the parent bug JDK-8263854?

@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 22, 2021

@shipilev would you mind creating a bug for me please?

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 23, 2021

@alblue alblue changed the title Use the blessed modifier order in java.xml 8264019: Use the blessed modifier order in java.xml Mar 23, 2021
@openjdk openjdk bot added the rfr label Mar 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Mar 23, 2021

The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is okay, Joe Wang can say.

@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Mar 23, 2021

Hi Alex, thanks for looking into this. As Alan mentioned, these code came from Apache, while we've made changes, we refrained from making minor ones (code style, format and etc.) as it would add unnecessary burden for future merges. I'd prefer not taking the changes to the source files that came from Apache. Thanks.

@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 23, 2021

OK, will abandon it. If someone could close the associated bug that would be appreciated.

@alblue alblue closed this Mar 23, 2021
@alblue alblue deleted the Sonar-XMLModifiers branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants