-
Notifications
You must be signed in to change notification settings - Fork 6k
8264019: Use the blessed modifier order in java.xml #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alblue! A progress list of the required criteria for merging this PR into |
Would someone mind creating a bug for me under the parent bug JDK-8263854? |
@shipilev would you mind creating a bug for me please? |
Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019 |
The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is okay, Joe Wang can say. |
Hi Alex, thanks for looking into this. As Alan mentioned, these code came from Apache, while we've made changes, we refrained from making minor ones (code style, format and etc.) as it would add unnecessary burden for future merges. I'd prefer not taking the changes to the source files that came from Apache. Thanks. |
OK, will abandon it. If someone could close the associated bug that would be appreciated. |
As a subtask of JDK-8263854 this cleans up the
java.xml
module to used the blessed modifier order.Progress
Issue
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3091/head:pull/3091
$ git checkout pull/3091
To update a local copy of the PR:
$ git checkout pull/3091
$ git pull https://git.openjdk.java.net/jdk pull/3091/head