Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263890: Broken links to Unicode.org #3093

Closed
wants to merge 2 commits into from
Closed

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Mar 19, 2021

Fixed several broken links to Unicode.org.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3093/head:pull/3093
$ git checkout pull/3093

To update a local copy of the PR:
$ git checkout pull/3093
$ git pull https://git.openjdk.java.net/jdk pull/3093/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 19, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 19, 2021

Webrevs

cl4es
cl4es approved these changes Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263890: Broken links to Unicode.org

Reviewed-by: redestad, joehw, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 4d9517d: 8263834: Work around gdb for HashtableEntry
  • 6fa6557: 8263825: Remove unused and commented out member from NTLMException
  • 77ebc11: 8263892: More modifier order fixes in java.base
  • 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
  • 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
  • 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
  • 0b5216a: 8263545: Convert jpackage to use Stream.toList()
  • ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
  • 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
  • d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/50ff0d4dd4c312906202c9a6e032e738d411ba62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 19, 2021
Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Some minor comments.

@@ -208,7 +208,7 @@
* <p>
* FULL_DECOMPOSITION corresponds to Normalization Form KD as
* described in
* <a href="http://www.unicode.org/unicode/reports/tr15/tr15-23.html">Unicode
* <a href="http://www.unicode.org/reports/tr15/tr15-23.html">Unicode
Copy link
Member

@JoeWang-Java JoeWang-Java Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the previous "Unicode Technical Report #15" was in http://unicode.org/reports/tr15/tr15-15.html, by tr15-23 it was "approved by the Unicode Technical Committee as a Unicode Standard Annex". Do we want to change the title to "Unicode Standard Annex #15"? Also, is Collator stuck with a particular revision (e.g. 23) or do we refer to the latest, e.g. "http://www.unicode.org/reports/tr15/"?

@@ -47,7 +47,7 @@
* text in a single paragraph or in a line of a single paragraph
* which has already been processed according to
* the Unicode 3.0 Bidi algorithm as defined in
* http://www.unicode.org/unicode/reports/tr9/ , version 13,
* http://www.unicode.org/reports/tr9/ , version 13,
Copy link
Member

@JoeWang-Java JoeWang-Java Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous references provided links e.g. "Unicode Standard Annex #9" instead of URL.

@@ -43,7 +43,7 @@
* The primary functions are to produce a normalized string and to detect whether
* a string is already normalized.
* The most commonly used normalization forms are those defined in
* http://www.unicode.org/unicode/reports/tr15/
* http://www.unicode.org/reports/tr15/
Copy link
Member

@JoeWang-Java JoeWang-Java Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@@ -473,7 +473,7 @@
* <hr width="50%">
* <h3>TODO</h3>
* <ul>
* <li><a href="http://www.unicode.org/unicode/reports/tr18/">Unicode Regular Expression Guidelines</a>
* <li><a href="http://www.unicode.org/reports/tr18/">Unicode Regular Expression Guidelines</a>
Copy link
Member

@JoeWang-Java JoeWang-Java Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that the references had been report numbers, e.g. Report/Annex #15, while this one the Title (by the way, the official title was "Unicode Regular Expressions"). The only exception seems to be the one in NormalizerBase.java where it referred to the number + title.

@naotoj
Copy link
Member Author

@naotoj naotoj commented Mar 19, 2021

Some minor comments.

Thanks, Joe. Addressed them as suggested.

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Looks all good. Thanks Naoto.

@naotoj
Copy link
Member Author

@naotoj naotoj commented Mar 19, 2021

/integrate

@openjdk openjdk bot closed this Mar 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2021

@naotoj Since your change was applied there have been 43 commits pushed to the master branch:

  • 4d9517d: 8263834: Work around gdb for HashtableEntry
  • 6fa6557: 8263825: Remove unused and commented out member from NTLMException
  • 77ebc11: 8263892: More modifier order fixes in java.base
  • 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
  • 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
  • 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
  • 0b5216a: 8263545: Convert jpackage to use Stream.toList()
  • ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
  • 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
  • d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/50ff0d4dd4c312906202c9a6e032e738d411ba62...master

Your commit was automatically rebased without conflicts.

Pushed as commit 96e5c3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@naotoj naotoj deleted the JDK-8263890 branch Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants