8263890: Broken links to Unicode.org #3093
Conversation
|
|
Webrevs
|
|
@naotoj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 43 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Some minor comments.
| @@ -208,7 +208,7 @@ | |||
| * <p> | |||
| * FULL_DECOMPOSITION corresponds to Normalization Form KD as | |||
| * described in | |||
| * <a href="http://www.unicode.org/unicode/reports/tr15/tr15-23.html">Unicode | |||
| * <a href="http://www.unicode.org/reports/tr15/tr15-23.html">Unicode | |||
There was a problem hiding this comment.
While the previous "Unicode Technical Report #15" was in http://unicode.org/reports/tr15/tr15-15.html, by tr15-23 it was "approved by the Unicode Technical Committee as a Unicode Standard Annex". Do we want to change the title to "Unicode Standard Annex #15"? Also, is Collator stuck with a particular revision (e.g. 23) or do we refer to the latest, e.g. "http://www.unicode.org/reports/tr15/"?
| @@ -47,7 +47,7 @@ | |||
| * text in a single paragraph or in a line of a single paragraph | |||
| * which has already been processed according to | |||
| * the Unicode 3.0 Bidi algorithm as defined in | |||
| * http://www.unicode.org/unicode/reports/tr9/ , version 13, | |||
| * http://www.unicode.org/reports/tr9/ , version 13, | |||
There was a problem hiding this comment.
Previous references provided links e.g. "Unicode Standard Annex #9" instead of URL.
| @@ -43,7 +43,7 @@ | |||
| * The primary functions are to produce a normalized string and to detect whether | |||
| * a string is already normalized. | |||
| * The most commonly used normalization forms are those defined in | |||
| * http://www.unicode.org/unicode/reports/tr15/ | |||
| * http://www.unicode.org/reports/tr15/ | |||
There was a problem hiding this comment.
Same as above.
| @@ -473,7 +473,7 @@ | |||
| * <hr width="50%"> | |||
| * <h3>TODO</h3> | |||
| * <ul> | |||
| * <li><a href="http://www.unicode.org/unicode/reports/tr18/">Unicode Regular Expression Guidelines</a> | |||
| * <li><a href="http://www.unicode.org/reports/tr18/">Unicode Regular Expression Guidelines</a> | |||
There was a problem hiding this comment.
Just a note that the references had been report numbers, e.g. Report/Annex #15, while this one the Title (by the way, the official title was "Unicode Regular Expressions"). The only exception seems to be the one in NormalizerBase.java where it referred to the number + title.
Thanks, Joe. Addressed them as suggested. |
|
/integrate |
|
@naotoj Since your change was applied there have been 43 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 96e5c3f. |
Fixed several broken links to Unicode.org.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3093/head:pull/3093$ git checkout pull/3093To update a local copy of the PR:
$ git checkout pull/3093$ git pull https://git.openjdk.java.net/jdk pull/3093/headThe text was updated successfully, but these errors were encountered: