8263892: More modifier order fixes in java.base

[alblue]

Additional changes found in java.base of final private -> private final. Filed with existing bug because it's the same module; can change to a different bug number if required.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263892: More modifier order fixes in java.base

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Claes Redestad (@cl4es - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3094/head:pull/3094
$ git checkout pull/3094

To update a local copy of the PR:
$ git checkout pull/3094
$ git pull https://git.openjdk.java.net/jdk pull/3094/head

[bridgekeeper]

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alblue The following labels will be automatically applied to this pull request:

• core-libs
• i18n
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (df9c1cb)

[openjdk]

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263892: More modifier order fixes in java.base

Reviewed-by: naoto, iris, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
• 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
• 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
• 0b5216a: 8263545: Convert jpackage to use Stream.toList()
• ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
• 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
• d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @irisclark, @cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[cl4es]

Can't reuse the bug IDs, sadly. Filed https://bugs.openjdk.java.net/browse/JDK-8263892 (note the new summary name to disambiguate)

[alblue]

/integrate

[openjdk]

@alblue
Your change (at version df9c1cb) is now ready to be sponsored by a Committer.

[cl4es]

/sponsor

[openjdk]

@cl4es @alblue Since your change was applied there have been 7 commits pushed to the master branch:

• 80d3ea0: 8263885: Use the blessed modifier order in java.sql/rowset/transation.xa
• 6737135: 8262083: vmTestbase/nsk/jvmti/SetEventNotificationMode/setnotif001/TestDescription.java failed with "No notification: event JVMTI_EVENT_FRAME_POP (61)"
• 57fc8e9: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent"
• 0b5216a: 8263545: Convert jpackage to use Stream.toList()
• ed701ea: 8262271: SA: Add new stress test that tests getting the stack trace of an active thread
• 30da9bc: 8263546: Add "findsym" command to clhsdb.html help file
• d41f751: 8247370: Clean up unused printing code in awt_PrintJob.cpp

Your commit was automatically rebased without conflicts.

Pushed as commit 77ebc11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.