8260862 JFR: New configure command for the jfr tool

[egahlin]

Hi,

Could I have a review of a new configure command for the jfr tool. Purpose is to simplify changing event settings:

$ jfr configure method-profiling=high gc=detailed
Configuration written successfully to:
/Users/Erik/custom.jfc

For more details, see CSR:
https://bugs.openjdk.java.net/browse/JDK-8260863

Testing:

• jdk/jdk/jfr
• JMC recording wizard

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260862: JFR: New configure command for the jfr tool

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3100/head:pull/3100
$ git checkout pull/3100

To update a local copy of the PR:
$ git checkout pull/3100
$ git pull https://git.openjdk.java.net/jdk pull/3100/head

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following labels will be automatically applied to this pull request:

• build
• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[egahlin]

/label remove build

[openjdk]

@egahlin
The build label was successfully removed.

[egahlin]

/csr

[openjdk]

@egahlin the issue for this pull request, JDK-8260862, already has an approved CSR request: JDK-8260863

[mlbridge]

Webrevs

• 01: Full - Incremental (78f1df9)
• 00: Full (3a95d90)

[egahlin]

/label remove hotspot-jfr

[openjdk]

@egahlin
The hotspot-jfr label was successfully removed.

[egahlin]

/label add hotspot-jfr

[openjdk]

@egahlin
The hotspot-jfr label was successfully added.

[mgronlun]

Looks good Erik, nice work.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260862: JFR: New configure command for the jfr tool

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 99 new commits pushed to the master branch:

• dbc9e4b: 8253795: Implementation of JEP 391: macOS/AArch64 Port
• b006f22: 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced
• 8307aa6: 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters
• c037e1e: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim()
• a1e717f: 8264146: Make Mutex point to rather than embed _name
• f69afba: 8263300: add HtmlId for the block containing a class's description.
• d82464f: 8263528: Make static page ids safe from collision with language elements
• d602ae0: 8263884: Clean up os::is_allocatable() across Posix platforms
• a9d287a: 8260388: Listing (sub)packages at package level of API documentation
• 8120064: 8263781: C2: Cannot hoist independent load above arraycopy
• ... and 89 more: https://git.openjdk.java.net/jdk/compare/96e5c3f1e0c0cfc9bbc77a357bdf3d169100c07e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

@egahlin Since your change was applied there have been 102 commits pushed to the master branch:

• 2593196: 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException
• 2a5e0dd: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"
• 374272f: 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling
• dbc9e4b: 8253795: Implementation of JEP 391: macOS/AArch64 Port
• b006f22: 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced
• 8307aa6: 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters
• c037e1e: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim()
• a1e717f: 8264146: Make Mutex point to rather than embed _name
• f69afba: 8263300: add HtmlId for the block containing a class's description.
• d82464f: 8263528: Make static page ids safe from collision with language elements
• ... and 92 more: https://git.openjdk.java.net/jdk/compare/96e5c3f1e0c0cfc9bbc77a357bdf3d169100c07e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4e708e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.