8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771

[DamonFool]

Hi all,

Build failures were observed when cds or g1gc was disabled due to initialize_static_field_for_dump/initialize_static_string_field_for_dump defined but not used.

This can be reproduced by:

• build without cds, or
• build without g1gc, or
• build on x86_32

This is because INCLUDE_CDS_JAVA_HEAP will be false for these cases [1].
Let's fix it.

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/utilities/macros.hpp#L612

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771

Reviewers

• Ioi Lam (@iklam - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3108/head:pull/3108
$ git checkout pull/3108

To update a local copy of the PR:
$ git checkout pull/3108
$ git pull https://git.openjdk.java.net/jdk pull/3108/head

[DamonFool]

/issue add JDK-8263908
/test
/label add hotspot-runtime
/cc hotspot-runtime

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool This issue is referenced in the PR title - it will now be updated.

[openjdk]

@DamonFool
The hotspot-runtime label was successfully added.

[openjdk]

@DamonFool The hotspot-runtime label was already applied.

[mlbridge]

Webrevs

• 00: Full (b6f8de1)

[iklam]

Looks good and trivial. Thanks!

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks for fixing Jie and apologies for the breakage.

David

[DamonFool]

Thanks @iklam and @dholmes-ora for your review.
/integrate

[openjdk]

@DamonFool Pushed as commit 35cd945.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.