Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771 #3108

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Mar 21, 2021

Hi all,

Build failures were observed when cds or g1gc was disabled due to initialize_static_field_for_dump/initialize_static_string_field_for_dump defined but not used.

This can be reproduced by:

  • build without cds, or
  • build without g1gc, or
  • build on x86_32

This is because INCLUDE_CDS_JAVA_HEAP will be false for these cases [1].
Let's fix it.

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/utilities/macros.hpp#L612


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3108/head:pull/3108
$ git checkout pull/3108

To update a local copy of the PR:
$ git checkout pull/3108
$ git pull https://git.openjdk.java.net/jdk pull/3108/head

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Mar 21, 2021

/issue add JDK-8263908
/test
/label add hotspot-runtime
/cc hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 21, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2021

@DamonFool This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2021

@DamonFool
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2021

@DamonFool The hotspot-runtime label was already applied.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 21, 2021

Webrevs

Loading

iklam
iklam approved these changes Mar 21, 2021
Copy link
Member

@iklam iklam left a comment

Looks good and trivial. Thanks!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 21, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Thanks for fixing Jie and apologies for the breakage.

David

Loading

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Mar 21, 2021

Thanks @iklam and @dholmes-ora for your review.
/integrate

Loading

@openjdk openjdk bot closed this Mar 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 21, 2021
@DamonFool DamonFool deleted the JDK-8263908 branch Mar 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 21, 2021

@DamonFool Pushed as commit 35cd945.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants