-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263905: Remove finalize methods for SocketInput/OutputStream #3111
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@kimbarrett Pushed as commit 47ef038. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks all for reviews. |
Please review this change to java.net.SocketInputStream and
java.net.SocketOutputStream, removing their "finalize" methods. These
methods are empty. Their purpose is to override and suppress the finalize
methods of their superclasses (FileInputStream and FileOutputStream,
respectively). But those classes had their finalize methods removed by
JDK-8192939 in JDK 12.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3111/head:pull/3111
$ git checkout pull/3111
To update a local copy of the PR:
$ git checkout pull/3111
$ git pull https://git.openjdk.java.net/jdk pull/3111/head