Skip to content

8263928: Add JAWT test files for mac #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 22, 2021

JAWT has testcase for windows and linux but no testcase is provided for mac.
We need to have a JAWT based testcase for mac, in similar lines to windows and linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3112/head:pull/3112
$ git checkout pull/3112

To update a local copy of the PR:
$ git checkout pull/3112
$ git pull https://git.openjdk.java.net/jdk pull/3112/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Mar 22, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263928: Add JAWT test files for mac

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 42104e5: 8263488: Verify CWarningWindow works with metal rendering pipeline
  • 5a7f22a: 8263579: ZGC: Concurrent mark hangs with debug loglevel
  • 35cd945: 8263908: Build fails due to initialize_static_field_for_dump defined but not used after JDK-8263771
  • cd45538: 8263771: Refactor javaClasses initialization code to isolate dumping code
  • 118a49f: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
  • cb742f9: 8255255: Update Apache Santuario (XML Signature) to version 2.2.1
  • d2c137d: 8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true
  • ab66d69: 8263138: Initialization of sun.font.SunFontManager.platformFontMap is not thread safe
  • 5b8233b: 8263871: On sem_destroy() failing we should assert
  • 96e5c3f: 8263890: Broken links to Unicode.org
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/d24e4cfef36026b781906a9e0c5cf519eb72696e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2021
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 26, 2021
@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2021
@prsadhuk prsadhuk deleted the jawt-mac branch March 26, 2021 11:30
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2021
@openjdk
Copy link

openjdk bot commented Mar 26, 2021

@prsadhuk Since your change was applied there have been 126 commits pushed to the master branch:

  • 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
  • e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
  • 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
  • bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
  • 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
  • fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state
  • 4e708e5: 8260862: JFR: New configure command for the jfr tool
  • 2593196: 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException
  • 2a5e0dd: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"
  • 374272f: 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling
  • ... and 116 more: https://git.openjdk.java.net/jdk/compare/d24e4cfef36026b781906a9e0c5cf519eb72696e...master

Your commit was automatically rebased without conflicts.

Pushed as commit f3eed05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants