8389219: Implement JEP 401: Value Objects (Preview) - #31120
Conversation
|
/issue add 8317277, 8317278, 8317279 |
|
👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into |
|
@MrSimms This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp, @iklam, @mcimadamore, @lahodaj, @dean-long, @jaikiran, @viktorklang-ora, @sspitsyn, @plummercj, @liach, @jddarcy, @dcubed-ojdk, @xmas92) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@MrSimms this pull request can not be integrated into git checkout 8317277
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
|
|
@MrSimms This issue is referenced in the PR title - it will now be updated. Adding additional issue to issue list: Adding additional issue to issue list: |
|
@MrSimms The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Reviewed-by: liach
Reviewed-by: dholmes, sspitsyn
Reviewed-by: mchevalier
…jectAllocValue/SampledObjectAllocValue.java Reviewed-by: fparain, cjplummer
Reviewed-by: sspitsyn
…to a different type" Reviewed-by: mchevalier, qamai
|
Waiting for "ready" to appear, the "/integrate auto" should process, then the "sponsor" flag will be added, then I can "/sponsor"... |
|
/integrate |
|
What happens if I do this early: /sponsor |
|
/sponsor |
|
Just to get it in the right order... if that makes a difference... |
|
tap, tap, tap... is this thing working? |
|
Anyone? Anyone? Bueller? Bueller? Bueller? |
|
Going to push as commit cc278db. |
|
@dcubed-ojdk @MrSimms Pushed as commit cc278db. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
@dcubed-ojdk The command |
This pull request implements the first preview of JEP 401: Value Objects (Preview). This pull request also includes the implementation of JEP 539: Strict Field Initialization in the JVM (Preview). That work was implemented in the same code base because JEP 401 depends on strict field initialization.
Sub-reviews, for spreading review debates are here:
This is the "master pull request" for the initial preview of JEP 401. Comments and review for a change this large will not scale well in a single pull request. This pull request serves as the vehicle for sign-off and integration into
jdk/master. Review comments should be directed to the appropriate "sub-review pull request" listed above.Note
The "sub-review pull requests" contain the same full set of code changes as this "master pull request" to preserve the full implementation context; the language compiler, JVM, and standard library changes are intertwined. The separate pull requests exist only to subdivide the review and related discussion by area.
Any resulting code changes should be made in
valhalla/lworld.valhalla/lworldis currently updated fromjdk/masterwhenever a weeklyjdktag is created. At that time, code changes fromvalhalla/lworldwill be propagated to this pull request and to all sub-review pull requests.Ultimately, review sign-off will be recorded on this "master pull request", and the "sub-review pull requests" will be closed without integration.
This pull request has a large surface area and frequently conflicts with
jdk/master. Refer tovalhalla/lworldfor the latest state of the project code, keeping in mind that it may lag several days behindjdk/master. Both repositories may be needed as references during review.Progress
Issues
Reviewers
Contributors
<dsimms@openjdk.org><dlsmith@openjdk.org><fparain@openjdk.org><thartmann@openjdk.org><rriggs@openjdk.org><vromero@openjdk.org><aboldtch@openjdk.org><acorn@openjdk.org><amenkov@openjdk.org><bhuang@openjdk.org><bmaillard@openjdk.org><chagedorn@openjdk.org><cjplummer@openjdk.org><cnorrbin@openjdk.org><coleenp@openjdk.org><dbeaumont@openjdk.org><dcubed@openjdk.org><dfenacci@openjdk.org><dholmes@openjdk.org><dsamersoff@openjdk.org><ecaspole@openjdk.org><enikitin@openjdk.org><epavlova@openjdk.org><fyang@openjdk.org><heidinga@openjdk.org><hseigel@openjdk.org><iklam@openjdk.org><iwalulya@openjdk.org><jbhateja@openjdk.org><jlahoda@openjdk.org><jlaskey@openjdk.org><jrose@openjdk.org><jsikstro@openjdk.org><lfoltan@openjdk.org><liach@openjdk.org><lmesnik@openjdk.org><matsaave@openjdk.org><mchevalier@openjdk.org><mchung@openjdk.org><mcimadamore@openjdk.org><mgronlun@openjdk.org><mhaessig@openjdk.org><ngasson@openjdk.org><pchilanomate@openjdk.org><phubner@openjdk.org><psandoz@openjdk.org><qamai@openjdk.org><rcastanedalo@openjdk.org><roland@openjdk.org><sadayapalam@openjdk.org><shade@openjdk.org><sjohanss@openjdk.org><skuksenko@openjdk.org><sspitsyn@openjdk.org><stefank@openjdk.org><stuefe@openjdk.org><tschatzl@openjdk.org><zmajo@openjdk.org><alanb@openjdk.org><jpai@openjdk.org><mdoerr@openjdk.org><rrich@openjdk.org><fjiang@openjdk.org><dyama@openjdk.org>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31120/head:pull/31120$ git checkout pull/31120Update a local copy of the PR:
$ git checkout pull/31120$ git pull https://git.openjdk.org/jdk.git pull/31120/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31120View PR using the GUI difftool:
$ git pr show -t 31120Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31120.diff
Using Webrev
Link to Webrev Comment