Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32 #3128

Closed
wants to merge 2 commits into from

Conversation

mgkwill
Copy link
Contributor

@mgkwill mgkwill commented Mar 22, 2021

Further fixes (in addition to #3104) for issue where BzhiTestI2L.java fails on x86_32. bzhiq instructions are only generated on x86_64.

This adds a skip to the test if Platform.isX86() and uses ((BmiTestCase) testCase).getTestCaseX64() && Platform.isX64() to decide when to use ((BmiTestCase_x64) testCase).getInstrPattern_x64() versus ((BmiTestCase) testCase).getInstrPattern() (x86_32 version of instruction)

Signed-off-by: Marcus G K Williams marcus.williams@intel.com


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32 ⚠️ Issue is not open.

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3128/head:pull/3128
$ git checkout pull/3128

To update a local copy of the PR:
$ git checkout pull/3128
$ git pull https://git.openjdk.java.net/jdk pull/3128/head

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2021

👋 Welcome back mgkwill! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2021
@mgkwill mgkwill changed the title 8263904: BzhiTestI2L.java fails on x86_32 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32 Mar 22, 2021
@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@mgkwill The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 22, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgkwill do you have plan to implement this optimization on 32-bit x86?

Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
@mgkwill
Copy link
Contributor Author

mgkwill commented Mar 22, 2021

@mgkwill do you have plan to implement this optimization on 32-bit x86?

Not originally but I'm looking at it now.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@mgkwill This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 036ae0e: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out
  • 5a51d70: 8247895: SHA1PRNGReseed.java is calling setSeed(0)
  • b2a52ea: 8263342: Add --connect option to jhsdb hsdb/clhsdb
  • 6b4c654: 8263776: [JVMCI] add helper to perform Java upcalls
  • b23228d: 8263914: CDS fails to find the default shared archive on x86_32
  • a5e7a89: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32
  • f62b100: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2021
@mgkwill
Copy link
Contributor Author

mgkwill commented Mar 22, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 22, 2021
@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@mgkwill
Your change (at version da6891c) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Mar 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2021
@openjdk
Copy link

openjdk bot commented Mar 23, 2021

@TobiHartmann @mgkwill Since your change was applied there have been 7 commits pushed to the master branch:

  • 036ae0e: 8225438: javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java failed with Read timed out
  • 5a51d70: 8247895: SHA1PRNGReseed.java is calling setSeed(0)
  • b2a52ea: 8263342: Add --connect option to jhsdb hsdb/clhsdb
  • 6b4c654: 8263776: [JVMCI] add helper to perform Java upcalls
  • b23228d: 8263914: CDS fails to find the default shared archive on x86_32
  • a5e7a89: 8263904: compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java fails on x86_32
  • f62b100: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices

Your commit was automatically rebased without conflicts.

Pushed as commit 7b6efd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mgkwill mgkwill deleted the 8263904_BzhiTestI2L_failure branch March 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants