8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

[prsadhuk]

Specification for method
javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle)
is not perfectly clear which method the call is delegated to.

Updated spec to clarify.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer) ⚠️ Review applies to c74fbd1
• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to c74fbd1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3146/head:pull/3146
$ git checkout pull/3146

Update a local copy of the PR:
$ git checkout pull/3146
$ git pull https://git.openjdk.java.net/jdk pull/3146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3146

View PR using the GUI difftool:
$ git pr show -t 3146

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3146.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (92749f76)
• 01: Full - Incremental (c74fbd1b)
• 00: Full (961b47b)

[prsadhuk]

Any reviewers?

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 281 new commits pushed to the master branch:

• 78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
• 88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
• a863ab6: 8264551: Unexpected warning when jpackage creates an exe
• 6e2b82a: 8264731: Introduce InstanceKlass::method_at_itable_or_null()
• 22b20f8: 8264424: Support OopStorage bulk allocation
• ab3be72: 8264863: Update JCov version to support JDK 17
• 774e5ae: 8264742: member variable _monitor of MonitorLocker is redundant
• 7a99a98: 8262316: Reducing locks in RSA Blinding
• d3fdd73: 8264173: [s390] Improve Hardware Feature Detection And Reporting
• 9d65039: 8263984: Invalidate printServices when there are no printers
• ... and 271 more: https://git.openjdk.java.net/jdk/compare/d24e4cfef36026b781906a9e0c5cf519eb72696e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

BTW the Rectangle does not have "w" and "h" fields

[prsadhuk]

/integrate

[openjdk]

@prsadhuk Since your change was applied there have been 281 commits pushed to the master branch:

• 78d1164: 8214455: Relocate CDS archived regions to the top of the G1 heap
• 88eb291: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr
• a863ab6: 8264551: Unexpected warning when jpackage creates an exe
• 6e2b82a: 8264731: Introduce InstanceKlass::method_at_itable_or_null()
• 22b20f8: 8264424: Support OopStorage bulk allocation
• ab3be72: 8264863: Update JCov version to support JDK 17
• 774e5ae: 8264742: member variable _monitor of MonitorLocker is redundant
• 7a99a98: 8262316: Reducing locks in RSA Blinding
• d3fdd73: 8264173: [s390] Improve Hardware Feature Detection And Reporting
• 9d65039: 8263984: Invalidate printServices when there are no printers
• ... and 271 more: https://git.openjdk.java.net/jdk/compare/d24e4cfef36026b781906a9e0c5cf519eb72696e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 016db40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.