Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to #3146

Closed
wants to merge 3 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 23, 2021

Specification for method
javax/swing/CellRendererPane.html#paintComponent(java.awt.Graphics,java.awt.Component,java.awt.Container,java.awt.Rectangle)
is not perfectly clear which method the call is delegated to.

Updated spec to clarify.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3146/head:pull/3146
$ git checkout pull/3146

Update a local copy of the PR:
$ git checkout pull/3146
$ git pull https://git.openjdk.java.net/jdk pull/3146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3146

View PR using the GUI difftool:
$ git pr show -t 3146

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3146.diff

…e) should clearly mention which method it delegates the call to
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Mar 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2021

Webrevs

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 1, 2021

Any reviewers?

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263907: Specification of CellRendererPane::paintComponent(..Rectangle) should clearly mention which method it delegates the call to

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 281 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2021
@mrserb
mrserb approved these changes Apr 7, 2021
@@ -200,7 +200,8 @@ public void paintComponent(Graphics g, Component c, Container p, int x, int y, i


/**
* Calls this.paintComponent() with the rectangles x,y,width,height fields.
* Calls this.paintComponent(g, c, p, r.x, r.y, r.w, r.h) where

This comment has been minimized.

@mrserb

mrserb Apr 7, 2021
Member

BTW the Rectangle does not have "w" and "h" fields

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 8, 2021

/integrate

@openjdk openjdk bot closed this Apr 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@prsadhuk Since your change was applied there have been 281 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 016db40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the prsadhuk:8263907 branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants