New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263496: MetalHighContrastTheme.getControlHighlight cleanup #3149
Conversation
|
src/java.desktop/share/classes/javax/swing/plaf/metal/MetalHighContrastTheme.java
Show resolved
Hide resolved
@prsadhuk This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 127 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
1 similar comment
/integrate |
@prsadhuk Since your change was applied there have been 205 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 0696fd0. |
@prsadhuk The command |
SonarCloud reports the potential issue with MetalHighContrastTheme.getControlHighlight where
controlHighlight
field is not used and the getControlHighlight() uses secondary field.Removed the unused field.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3149/head:pull/3149
$ git checkout pull/3149
To update a local copy of the PR:
$ git checkout pull/3149
$ git pull https://git.openjdk.java.net/jdk pull/3149/head