Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263496: MetalHighContrastTheme.getControlHighlight cleanup #3149

wants to merge 1 commit into from


Copy link

@prsadhuk prsadhuk commented Mar 23, 2021

SonarCloud reports the potential issue with MetalHighContrastTheme.getControlHighlight where controlHighlight field is not used and the getControlHighlight() uses secondary field.

public ColorUIResource getControlHighlight() {
        // This was super.getSecondary3();
        return secondary2;

Removed the unused field.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8263496: MetalHighContrastTheme.getControlHighlight cleanup



To checkout this PR locally:
$ git fetch pull/3149/head:pull/3149
$ git checkout pull/3149

To update a local copy of the PR:
$ git checkout pull/3149
$ git pull pull/3149/head

Copy link

bridgekeeper bot commented Mar 23, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2021
Copy link

openjdk bot commented Mar 23, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Mar 23, 2021
Copy link

mlbridge bot commented Mar 23, 2021


Copy link

openjdk bot commented Mar 26, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8263496: MetalHighContrastTheme.getControlHighlight cleanup

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the master branch:

  • f3eed05: 8263928: Add JAWT test files for mac
  • 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
  • e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
  • 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
  • bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
  • 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
  • fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state
  • 4e708e5: 8260862: JFR: New configure command for the jfr tool
  • 2593196: 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException
  • 2a5e0dd: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/ failed with "ERROR: eventSet1.size() != 3 :: 2"
  • ... and 117 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 26, 2021
Copy link
Contributor Author

prsadhuk commented Apr 1, 2021


1 similar comment
Copy link
Contributor Author

prsadhuk commented Apr 1, 2021


@openjdk openjdk bot closed this Apr 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2021
Copy link

openjdk bot commented Apr 1, 2021

@prsadhuk Since your change was applied there have been 205 commits pushed to the master branch:

  • 6cf1095: 8264484: Replace uses of StringBuffer with StringBuilder in jdk.hotspot.agent
  • d2df9a7: 8264331: Use the blessed modifier order in jdk.compiler
  • 0228734: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 3997c99: 8264222: Use switch expression in jshell where possible
  • 39f0b27: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total
  • de495df: 8264413: Data is written to file header even if its CRC32 was calculated
  • 52d8a22: 8264054: Bad XMM performance on java.lang.MathBench.sqrtDouble
  • 16acfaf: 8012229: [lcms] Improve performance of color conversion for images with alpha channel
  • cb70ab0: 8263235: sanity/client/SwingSet/src/ failed throwing java.lang.NoClassDefFoundError
  • e2ec997: 8263551: Provide shared lock-free FIFO queue implementation
  • ... and 195 more:

Your commit was automatically rebased without conflicts.

Pushed as commit 0696fd0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link

openjdk bot commented Apr 1, 2021

@prsadhuk The command integrate can only be used in open pull requests.

@prsadhuk prsadhuk deleted the 8263496 branch April 1, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
integrated Pull request has been integrated swing
2 participants