8264051: Remove unused TRAPS parameters from runtime functions

[coleenp]

This change removes the TRAPS parameter from compute_modifier_flags(), lookup_instance_method_in_klasses and nest_host_error.

There's a progressive effort to remove cases where the last parameter of a function is THREAD, and it's unclear why it is ignoring an exception or whether an exception is expected, if it doesn't subsequently have a check for HAS_PENDING_EXCEPTION.

Tested locally with tier1 tests and tier1 tests on 4 Oracle platforms in progress.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264051: Remove unused TRAPS parameters from runtime functions

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 57f5254
• David Holmes (@dholmes-ora - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3157/head:pull/3157
$ git checkout pull/3157

To update a local copy of the PR:
$ git checkout pull/3157
$ git pull https://git.openjdk.java.net/jdk pull/3157/head

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3ce0784)
• 00: Full (57f5254)

[iklam]

LGTM. Thanks for doing the cleanup.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264051: Remove unused TRAPS parameters from runtime functions

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 0b2aa1b: 8263978: Clarify why 0 argument is ignored in SecureRandom::setSeed
• 15bcf6d: 8264055: backout JDK-8248904 in order to resubmit with additional attribution.
• 2425462: 8263903: Use Cleaner instead of finalize to auto stop Timer thread
• 35102cb: 8263992: Remove dead code NativeLookup::base_library_lookup
• 91d86e6: 8263572: Output from jstack mixed mode is misaligned
• 47ef038: 8263905: Remove finalize methods for SocketInput/OutputStream
• 1c9817b: 8261479: CDS runtime code should check exceptions
• 087c8bf: 8264041: Incorrect comments for ParallelCompactData::summarize_dense_prefix
• c087f3e: 8263995: Incorrect double-checked locking in Types.arraySuperType()
• d7268fa: 8251942: PrintStream specification is not clear which flush method is automatically invoked
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/8c1ab38ee20ed61fefbb64b6a9ee605c52d2cb4e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Nice cleanup Coleen!

I have a further suggested change to simplify things further - see below.

Thanks,
David

[dholmes-ora]

Looks good!

Thanks,
David

[coleenp]

Thanks for reviewing!
/integrate

[openjdk]

@coleenp Since your change was applied there have been 28 commits pushed to the master branch:

• 5d7e93c: 8264004: Don't use TRAPS if no exceptions are thrown
• 9ee0b9a: 8264052: Shenandoah: Backout 8263832
• e55aa41: 8263899: HttpClient throws NPE in AuthenticationFilter when parsing www-authenticate head
• 6c0fbf7: 8254196: jshell infinite loops when startup script contains System.exit call
• a79f095: 8263721: Unify oop casting
• 329697b: 8263358: Update java.lang to use instanceof pattern variable
• ae9af57: 8264001: JFR: Modernize implementation
• fad8484: 8263411: Convert jshell tool to use Stream.toList()
• 06d46d6: 8264008: Incorrect metaspace statistics after JEP 387 when UseCompressedClassPointers is off
• 45e1bab: 8264091: Use the blessed modifier order in java.logging
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/8c1ab38ee20ed61fefbb64b6a9ee605c52d2cb4e...master

Your commit was automatically rebased without conflicts.

Pushed as commit bc91596.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.