-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8264052: Shenandoah: Backout 8263832 #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
|
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
|
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@zhengyu123 Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9ee0b9a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
TestStringDedupStress started to fail after JDK-8263832.
JDK-8263832 is incorrect, because Threads::possibly_parallel_threads_do() only iterates over Java and VM threads, it should be backed out. The original works correctly.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3158/head:pull/3158$ git checkout pull/3158To update a local copy of the PR:
$ git checkout pull/3158$ git pull https://git.openjdk.java.net/jdk pull/3158/head