-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8264062: Use the blessed modifier order in jdk.jfr #3161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alblue! A progress list of the required criteria for merging this PR into |
4812e09
to
ec31fbd
Compare
Would someone mind reviewing this? @mgronlun perhaps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alex, looks good. Thank you.
@alblue this pull request can not be integrated into git checkout Sonar-JFRModifiers
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
ec31fbd
to
175d790
Compare
@alblue This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Pushed as commit e47dfb8. |
This replaces patterns such as "final public" with "public final" to bring the modifiers in the standard order for the jdk.jfr module.
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3161/head:pull/3161
$ git checkout pull/3161
To update a local copy of the PR:
$ git checkout pull/3161
$ git pull https://git.openjdk.java.net/jdk pull/3161/head