Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store. #3172

Closed
wants to merge 1 commit into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Mar 24, 2021

Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

Reviewers

Contributors

  • Erwin Morrhey <erwin.morrhey@gluonhq.com>

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3172/head:pull/3172
$ git checkout pull/3172

To update a local copy of the PR:
$ git checkout pull/3172
$ git pull https://git.openjdk.java.net/jdk pull/3172/head

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 24, 2021

/contributor add Erwin Morrhey erwin.morrhey@gluonhq.com

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 24, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@andyherrick
Contributor Erwin Morrhey <erwin.morrhey@gluonhq.com> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@andyherrick The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

I can confirm that this restores the fix for JDK-8248904. There are no diffs in any jpackage file between the commit prior to the backout and this PR.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

Co-authored-by: Erwin Morrhey <erwin.morrhey@gluonhq.com>
Reviewed-by: kcr, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 24, 2021
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Mar 24, 2021

/integrate

@openjdk openjdk bot closed this Mar 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@andyherrick Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit deda80f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the JDK-8264057 branch Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants