-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store. #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/contributor add Erwin Morrhey erwin.morrhey@gluonhq.com |
|
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
|
@andyherrick |
|
@andyherrick The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this restores the fix for JDK-8248904. There are no diffs in any jpackage file between the commit prior to the backout and this PR.
|
@andyherrick This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@andyherrick Since your change was applied there have been 18 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit deda80f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.
Progress
Issue
Reviewers
Contributors
<erwin.morrhey@gluonhq.com>Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3172/head:pull/3172$ git checkout pull/3172To update a local copy of the PR:
$ git checkout pull/3172$ git pull https://git.openjdk.java.net/jdk pull/3172/head