Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263615: Cleanup tightly_coupled_allocation #3174

Closed
wants to merge 5 commits into from

Conversation

neliasso
Copy link

@neliasso neliasso commented Mar 24, 2021

Small cleanup of tightly_couple_allocation as a follow up to JDK-8263361.

  1. The slow_region argument isn't used from any context.
  2. The use in LibraryCallKit::inline_string_toBytesU() can never be null since the alloca is directly above. Removing null check and associated code.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3174/head:pull/3174
$ git checkout pull/3174

To update a local copy of the PR:
$ git checkout pull/3174
$ git pull https://git.openjdk.java.net/jdk pull/3174/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2021

👋 Welcome back neliasso! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2021

@neliasso The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 24, 2021
@neliasso neliasso marked this pull request as ready for review March 24, 2021 14:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@neliasso This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263615: Cleanup tightly_coupled_allocation

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • 447e0df: 8263769: simplify PhaseMacroExpand::extract_call_projections()
  • 99b4bab: 8263188: JSSE should fail fast if there isn't supported signature algorithm
  • 6678b01: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2fa6a3c: 8264006: Fix AOT library loading on CPUs with 256-byte dcache line
  • c986457: 8264329: Z cannot be 1 for Diffie-Hellman key agreement
  • a209ed0: 8263670: pmap and pstack in jhsdb do not work on debug server
  • 38e0a58: 8264273: macOS: zero VM is broken due to no member named 'is_cpu_emulated' after JDK-8261966
  • c9d2d02: 8263632: Improve exception handling of APIs in classLoader.cpp
  • 59ed1fa: 8264087: Use the blessed modifier order in jdk.jconsole
  • 054e0a4: 8264017: Correctly report inlined frame in JFR sampling
  • ... and 54 more: https://git.openjdk.java.net/jdk/compare/329697b02ee66b5bb767634dbf3ba19f6624c8d3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@neliasso
Copy link
Author

/integrate

@openjdk openjdk bot closed this Mar 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@neliasso Since your change was applied there have been 87 commits pushed to the master branch:

  • 4ea6abf: 8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates
  • 8735259: 8264333: Use the blessed modifier order in jdk.jshell
  • d2a63f2: 8264360: Loop strip mining verification fails with "should be on the backedge"
  • 8100a20: 8263971: C2 crashes with SIGFPE with -XX:+StressGCM and -XX:+StressIGVN
  • bcdf469: 8264337: VM crashed when -XX:+VerifySharedSpaces
  • 1a681fa: 8263560: Remove needless wrapping with BufferedInputStream
  • 182b11c: 8264016: [JVMCI] add some thread local fields for use by JVMCI
  • 8cf1c62: 8263754: HexFormat 'fromHex' methods should be static
  • a5d7de2: 8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec
  • 128c0c9: 8248418: jpackage fails to extract main class and version from app module linked in external runtime
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/329697b02ee66b5bb767634dbf3ba19f6624c8d3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4ffa41c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants