8263603: Remove leftovers of "FPE_FLT..." type signals from regular signal handling code #3175
Signal handling code is complex as it is, this enhancement removes, incorrect, catching & handling of
It's incorrect, because:
If we were to catch
In anticipation of such scenarios we have a generic handling of
Thank you David for the review.
I figured that if we were to get such unexpected signal we would be in unknown territory, but I can change it to assert instead.
On 26/03/2021 1:03 am, Gerard Ziemski wrote:
Note that I also suggested that we throw the exception. I don't think we
While we no longer use the x87 co-processor in hotspot code, I'm
I'm not sure we were ever enabling x87 signals. I seriously doubt we ever wanted to do that (on purpose) or that we had it in fact ever enabled.
3rd parties could/should add their own signal exception handling for x87 FPU if they want it. Those are very domain specific, and if they wanted them they would certainly not want us handling them.
I think this is a very dead code, that unnecessarily complicates our signal handling with zero benefit and I personally would love to see it go away, especially now that we have an understanding of what FPE_FLT signals are. There is enough signal handling code that we do need to support as it is.
Is that a good enough argument, or are you still unconvinced and you don't want to see it fixed?
On 27/03/2021 1:01 am, Gerard Ziemski wrote:
But this isn't just about x87 signals. The use of SSE can also generate
The fact we turn a SIGFPE FPE_FLTDIV into a Java ArithmeticException may
Sorry, if this was x87 only then I could accept the dead code argument,
@gerard-ziemski This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!