Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8220266: add support for additional metadata in add/remove programs #3178

Closed

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 24, 2021

Add support for --about-url, --win-update-url and --win-help-url parameters.
Implementation for --about-url is provided on Windows only.
This parameter may be supported on Linux as well. https://bugs.openjdk.java.net/browse/JDK-8264144 is tracking this task.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8220266: add support for additional metadata in add/remove programs

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3178/head:pull/3178
$ git checkout pull/3178

To update a local copy of the PR:
$ git checkout pull/3178
$ git pull https://git.openjdk.java.net/jdk pull/3178/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 24, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Mar 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2021

Webrevs

Copy link

@andyherrick andyherrick left a comment

Looks OK.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8220266: add support for additional metadata in add/remove programs

Reviewed-by: herrick, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 37f494c: 8260619: Add final modifier to several DataFlavor static fields
  • cfc9aa3: 8264002: Delete outdated assumptions about ColorSpace initialization
  • 623f0b6: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
  • 1a13c9e: 8263473: Update annotation terminology (2)
  • 3e751a5: 8263198: javadoc HELP page

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 24, 2021
@alexeysemenyukoracle
Copy link
Member Author

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 24, 2021

/integrate

@openjdk openjdk bot closed this Mar 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2021

@alexeysemenyukoracle Since your change was applied there have been 5 commits pushed to the master branch:

  • 37f494c: 8260619: Add final modifier to several DataFlavor static fields
  • cfc9aa3: 8264002: Delete outdated assumptions about ColorSpace initialization
  • 623f0b6: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
  • 1a13c9e: 8263473: Update annotation terminology (2)
  • 3e751a5: 8263198: javadoc HELP page

Your commit was automatically rebased without conflicts.

Pushed as commit 3d7f912.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants