Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223051: support loops with long (64b) trip counts #318

Closed
wants to merge 2 commits into from

Conversation

@rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Sep 23, 2020

Last webrev was:

https://cr.openjdk.java.net/~roland/8223051/webrev.03/

This PR includes a few minor changes:

8252696 (Loop unswitching may cause out of bound array load to be
executed) was the only bug that was uncovered by extended testing and
it's fixed now.

This was previously reviewed by Tobias, Vladimir and John. Given the
last changes were either requested by reviewers or a straighforward
improvement to statistics, and unless someone objects, I intend to
push this in the next few days with the reviewer list I just
mentioned.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8223051: support loops with long (64b) trip counts

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/318/head:pull/318
$ git checkout pull/318

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2020

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@rwestrel The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2020

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223051: support loops with long (64b) trip counts

Reviewed-by: vlivanov, thartmann, jrose

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • c7f0064: 8253899: Make IsClassUnloadingEnabled signature match specification
  • aad3cf4: 8254234: Add test library stream object builder
  • 4184959: 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher.
  • 05459df: 8253765: C2: Control randomization in StressLCM and StressGCM
  • 6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 24, 2020
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@rose00
rose00 approved these changes Sep 28, 2020
Copy link
Contributor

@rose00 rose00 left a comment

Good to go. Thanks for patiently working all the issues.

@rwestrel
Copy link
Contributor Author

@rwestrel rwestrel commented Sep 29, 2020

/test

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@rwestrel you need to get approval to run the tests in tier1 for commits up until 2dd3a15

@openjdk openjdk bot added the test-request label Sep 29, 2020
@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 29, 2020

/test approve

@openjdk openjdk bot removed the test-request label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

Could not create test job

@rwestrel rwestrel force-pushed the rwestrel:JDK-8223051 branch from 2dd3a15 to 823f8ba Oct 12, 2020
@rwestrel
Copy link
Contributor Author

@rwestrel rwestrel commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@rwestrel Since your change was applied there have been 90 commits pushed to the master branch:

  • e9be2db: 8253453: SourceFileInfoTable should be allocated lazily
  • e10b538: 8243962: Various JVM TI tests time out using JFR on Windows
  • a1a3e9d: 8254882: ZGC: Use static_assert instead of guarantee
  • 8edc2f0: 8254912: ZGC: Change ZCollectionInterval type to double
  • 672f566: 8254874: ZGC: JNIHandleBlock verification failure in stack watermark processing
  • 98a395a: 8254880: ZGC: Let ZList iterators be alias templates
  • 011dd0d: 8254824: SignalHandlerMark have no purpose
  • 736e077: 8254178: Remove .hgignore
  • 51a865d: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
  • ... and 80 more: https://git.openjdk.java.net/jdk/compare/a6c23b7753b9196befdd0f995faf5c77249c4247...master

Your commit was automatically rebased without conflicts.

Pushed as commit e76de18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants