-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8253014: OopStorage bulk release logs entries multiple times #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett |
@kimbarrett Setting summary to:
|
@kimbarrett To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks trivial, after reading the code for a minute. BTW, maybe the message should be "releasing", not "released", as the actual release had not happened yet at the time of logging.
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Note the commit message that bot suggested is wrong, includes PR metadata. |
/summary Remove excess logging. |
@kimbarrett Updating existing summary to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and confirming triviality
I changed the log messages to say "releasing" rather than "released" as suggested. Also fixed the summary, which hit a Skara bug that I thought had been fixed, but apparently hadn't quite been rolled out at the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good.
/integrate |
@kimbarrett Since your change was applied there have been 8 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 154b8cf. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change that removes some incorrect / duplicate
logging from OopStorage's bulk release operation. The correct logging is
done about 10 lines later.
Testing: mach5 tier1.
/label hotspot-gc
/summary Remove excess logging.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/319/head:pull/319
$ git checkout pull/319