Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253014: OopStorage bulk release logs entries multiple times #319

Closed
wants to merge 2 commits into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Sep 23, 2020

Please review this trivial change that removes some incorrect / duplicate
logging from OopStorage's bulk release operation. The correct logging is
done about 10 lines later.

Testing: mach5 tier1.

/label hotspot-gc
/summary Remove excess logging.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253014: OopStorage bulk release logs entries multiple times

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/319/head:pull/319
$ git checkout pull/319

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2020

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the hotspot-gc label Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@kimbarrett
The hotspot-gc label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@kimbarrett Setting summary to:

Remove excess logging.
<!-- Anything below this marker will be automatically updated, please do not edit manually! -->
---------
### Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed

### Issue
* [JDK-8253014](https://bugs.openjdk.java.net/browse/JDK-8253014): OopStorage bulk release logs entries multiple times


### Download
`$ git fetch https://git.openjdk.java.net/jdk pull/319/head:pull/319`
`$ git checkout pull/319`

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@kimbarrett To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

Loading

@kimbarrett kimbarrett marked this pull request as ready for review Sep 23, 2020
@openjdk openjdk bot added the rfr label Sep 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2020

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks trivial, after reading the code for a minute. BTW, maybe the message should be "releasing", not "released", as the actual release had not happened yet at the time of logging.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253014: OopStorage bulk release logs entries multiple times

Remove excess logging.

Reviewed-by: shade, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • f765a7f: 8252712: move doclint to jdk.javadoc module
  • c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
  • 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 23, 2020
@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 23, 2020

Note the commit message that bot suggested is wrong, includes PR metadata.

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 23, 2020

/summary Remove excess logging.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@kimbarrett Updating existing summary to Remove excess logging.

Loading

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and confirming triviality

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 24, 2020

I changed the log messages to say "releasing" rather than "released" as suggested. Also fixed the summary, which hit a Skara bug that I thought had been fixed, but apparently hadn't quite been rolled out at the time.

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Still good.

Loading

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 24, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@kimbarrett Since your change was applied there have been 8 commits pushed to the master branch:

  • ba174af: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 3320fc0: 8253372: [TESTBUG] update tests which require jvmti - hotspot
  • f765a7f: 8252712: move doclint to jdk.javadoc module
  • c21690b: 8253464: ARM32 Zero: atomic_copy64 is incorrect, breaking volatile stores
  • 0bc01da: 8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks
  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions

Your commit was automatically rebased without conflicts.

Pushed as commit 154b8cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kimbarrett kimbarrett deleted the oopstorage_logging branch Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants