Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 25, 2021

Add missing escape single quote (') and typo fix


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3193/head:pull/3193
$ git checkout pull/3193

To update a local copy of the PR:
$ git checkout pull/3193
$ git pull https://git.openjdk.java.net/jdk pull/3193/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8264165: jpackage BasicTest fails after JDK-8220266: Check help text … 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters Mar 25, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 25, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters

Reviewed-by: herrick, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c037e1e: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2021
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original change in JDK-8220266 shows the introduction
of three single quotes and this fix addresses all three along
with another typo.

Thumbs up.

@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2021
@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@alexeysemenyukoracle Since your change was applied there has been 1 commit pushed to the master branch:

  • c037e1e: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim()

Your commit was automatically rebased without conflicts.

Pushed as commit 8307aa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants