Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264178: Unused method Threads::nmethods_do #3199

wants to merge 1 commit into from


Copy link

@albertnetymk albertnetymk commented Mar 25, 2021

Trivial change of removing an unused method.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed




To checkout this PR locally:
$ git fetch pull/3199/head:pull/3199
$ git checkout pull/3199

To update a local copy of the PR:
$ git checkout pull/3199
$ git pull pull/3199/head

Copy link

@bridgekeeper bridgekeeper bot commented Mar 25, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 25, 2021
Copy link

@openjdk openjdk bot commented Mar 25, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Copy link

@mlbridge mlbridge bot commented Mar 25, 2021


Copy link

@coleenp coleenp left a comment

Looks good to me.

Copy link

@openjdk openjdk bot commented Mar 25, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8264178: Unused method Threads::nmethods_do

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
  • fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state
  • 4e708e5: 8260862: JFR: New configure command for the jfr tool
  • 2593196: 8264161: BigDecimal#stripTrailingZeros can throw undocumented ArithmeticException
  • 2a5e0dd: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/ failed with "ERROR: eventSet1.size() != 3 :: 2"
  • 374272f: 8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling
  • dbc9e4b: 8253795: Implementation of JEP 391: macOS/AArch64 Port
  • b006f22: 4833719: (bf) Views of MappedByteBuffers are not MappedByteBuffers, and cannot be forced
  • 8307aa6: 8264165: jpackage BasicTest fails after JDK-8220266: Check help text contains plaform specific parameters
  • c037e1e: 8263454: ignores the result of String.trim()
  • ... and 1 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 25, 2021
Copy link

@dholmes-ora dholmes-ora left a comment

Well spotted. This was missed by another cleanup under JDK-8244658.


Copy link
Member Author

@albertnetymk albertnetymk commented Mar 26, 2021

Thanks for the review.


@openjdk openjdk bot closed this Mar 26, 2021
@openjdk openjdk bot added integrated and removed ready labels Mar 26, 2021
@albertnetymk albertnetymk deleted the albertnetymk:thread branch Mar 26, 2021
@openjdk openjdk bot removed the rfr label Mar 26, 2021
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@albertnetymk Since your change was applied there have been 21 commits pushed to the master branch:

  • 33c94ff: 8263376: CTW (Shenandoah): assert(mems <= 1) failed: No node right after call if multiple mem projections
  • 4e74de4: 8264111: (fs) Leaking NativeBuffers in case of errors during
  • 57115fa: 8189198: Add "forRemoval = true" to Applet API deprecations
  • b8122d6: 8264220: jdk/javadoc/doclet/testRelatedPackages/ fails to compile
  • 507b690: 8264126: Remove TRAPS/THREAD parameter for class loading functions
  • f3eed05: 8263928: Add JAWT test files for mac
  • 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
  • e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
  • 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
  • bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
  • ... and 11 more:

Your commit was automatically rebased without conflicts.

Pushed as commit 3a28dc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants