8264220: jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile

[DamonFool]

Hi all,

jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile.
Let's fix it.

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264220: jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile

Reviewers

• Hannes Wallnöfer (@hns - Reviewer)

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3208/head:pull/3208
$ git checkout pull/3208

To update a local copy of the PR:
$ git checkout pull/3208
$ git pull https://git.openjdk.java.net/jdk pull/3208/head

[DamonFool]

/issue add JDK-8264220
/test
/label add javadoc
/cc javadoc

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool This issue is referenced in the PR title - it will now be updated.

[openjdk]

@DamonFool
The javadoc label was successfully added.

[openjdk]

@DamonFool The javadoc label was already applied.

[mlbridge]

Webrevs

• 00: Full (8529cc0)

[hns]

Sorry for the inconvenience, and thanks for looking into this and fixing it. It's quite easy to trip over how jtreg caches libraries.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264220: jdk/javadoc/doclet/testRelatedPackages/TestRelatedPackages.java fails to compile

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
• 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
• bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
• 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
• fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Thanks @hns for your review.

Do you think it's trivial and can be pushed right now?
Thanks.

[hns]

I have tested the fix running jtreg in standalone mode and without precompiled test libraries. I verified the fix solves the problem, so yes, I think this can be pushed.

What I do not understand is why there are other javadoc tests that build toolbox.ToolBox and do not have the jdk.compiler @modules tags, but still work in standalone mode without preexisiting JTwork directory. But that's a different problem, so I think it's safe to push this change.

[DamonFool]

Thanks @hns .
/integrate

[openjdk]

@DamonFool Since your change was applied there have been 8 commits pushed to the master branch:

• 507b690: 8264126: Remove TRAPS/THREAD parameter for class loading functions
• f3eed05: 8263928: Add JAWT test files for mac
• 4fbb7c2: 8263472: Specification of JComponent::updateUI should document that the default implementation does nothing
• e47dfb8: 8264062: Use the blessed modifier order in jdk.jfr
• 5a930c4: 8264135: UnsafeGetStableArrayElement should account for different JIT implementation details
• bb354b9: 8264166: OopStorage should support specifying MEMFLAGS for allocations
• 41657b1: 8261551: Remove special CDS handling in Metaspace::allocate
• fe8ef32: 8264151: ciMethod::ensure_method_data() should return false is loading resulted in empty state

Your commit was automatically rebased without conflicts.

Pushed as commit b8122d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.