Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks #321

Closed
wants to merge 1 commit into from

Conversation

@RealLucy
Copy link

@RealLucy RealLucy commented Sep 23, 2020

This change was already fully reviewed before the Mercurial to Git transition.
Reviewed-by: thartmann (TobiHartmann), mdoerr (TheRealMDoerr).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/321/head:pull/321
$ git checkout pull/321

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 23, 2020

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@RealLucy The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot label Sep 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 23, 2020

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

I had already reviewed it on the mailing list.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@RealLucy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8250635: MethodArityHistogram should use Compile_lock in favour of fancy checks

Reviewed-by: mdoerr, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions
  • e4d0e5a: 8253516: ZGC: Remove card table functions
  • 3fe5886: 8252696: Loop unswitching may cause out of bound array load to be executed
  • 226faa5: 8253241: Update comment on java_suspend_self_with_safepoint_check()
  • bd67975: 8253349: Remove unimplemented SharedRuntime::native_method_throw_unsupported_operation_exception_entry
  • bddb822: 8253240: No javadoc for DecimalFormatSymbols.hashCode()
  • c68a31d: 8253499: Problem list runtime/cds/DeterministicDump.java
  • 93a2018: 8252195: AWT Accessibility API nested classes rely on default constructors
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2020
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

@RealLucy
Copy link
Author

@RealLucy RealLucy commented Sep 23, 2020

/integrate

@RealLucy
Copy link
Author

@RealLucy RealLucy commented Sep 23, 2020

@openjdk openjdk bot closed this Sep 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 23, 2020

@RealLucy Since your change was applied there have been 14 commits pushed to the master branch:

  • 812b39f: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary
  • 5f1d612: 8253397: Ensure LogTag types are sorted
  • b8ea80a: 8253457: Remove unimplemented register stack functions
  • e4d0e5a: 8253516: ZGC: Remove card table functions
  • 3fe5886: 8252696: Loop unswitching may cause out of bound array load to be executed
  • 226faa5: 8253241: Update comment on java_suspend_self_with_safepoint_check()
  • bd67975: 8253349: Remove unimplemented SharedRuntime::native_method_throw_unsupported_operation_exception_entry
  • bddb822: 8253240: No javadoc for DecimalFormatSymbols.hashCode()
  • c68a31d: 8253499: Problem list runtime/cds/DeterministicDump.java
  • 93a2018: 8252195: AWT Accessibility API nested classes rely on default constructors
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0f26ab16ddf10cefc0b528aa12c7c2378a864063...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0bc01da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants