Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264240: [macos_aarch64] enable appcds support after JDK-8263002 #3221

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Mar 26, 2021

Please review this small patch for macos_aarch64.
It reverts small part of jep-391 where we disabled cds for macos_aarch64.
After JDK-8263002 is fixed, the appcds can be enabled back on macos_aarch64.
CDS related tests in tier1 now pass


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264240: [macos_aarch64] enable appcds support after JDK-8263002

Reviewers

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3221/head:pull/3221
$ git checkout pull/3221

To update a local copy of the PR:
$ git checkout pull/3221
$ git pull https://git.openjdk.java.net/jdk pull/3221/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 26, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@VladimirKempik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Mar 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 26, 2021

Webrevs

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Mar 26, 2021

/label add hotspot

Loading

@openjdk openjdk bot added the hotspot label Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@VladimirKempik
The hotspot label was successfully added.

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Mar 26, 2021

/cc hotspot-runtime

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@VladimirKempik
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264240: [macos_aarch64] enable appcds support after JDK-8263002

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7284f01: 8262110: DST starts from incorrect time in 2038

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 26, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Mar 26, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@VladimirKempik Since your change was applied there has been 1 commit pushed to the master branch:

  • 7284f01: 8262110: DST starts from incorrect time in 2038

Your commit was automatically rebased without conflicts.

Pushed as commit d6bb153.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@VladimirKempik VladimirKempik deleted the JDK-8264240 branch Mar 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 29, 2021

Mailing list message from David Holmes on build-dev:

On Fri, 26 Mar 2021 17:18:22 GMT, Vladimir Kempik <vkempik at openjdk.org>
wrote:

Please review this small patch for macos_aarch64.
It reverts small part of jep-391 where we disabled cds for macos_aarch64.
After JDK-8263002 is fixed, the appcds can be enabled back on macos_aarch64.
CDS related tests in tier1 now pass

That tier 1 testing may not have been sufficient. With CDS enabled you
will likely hit crashes due to JDK-8262894.

David
-----

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants