Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264309: JFR: Improve .jfc parser #3222

Closed
wants to merge 2 commits into from
Closed

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Mar 26, 2021

Hi,

Could I have a review of a fix that removes unnecessary number of StringBuilder allocations. Events are now referred to by name, not path. The code should reflect that. The method getSettings() is not used and can be removed.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3222/head:pull/3222
$ git checkout pull/3222

Update a local copy of the PR:
$ git checkout pull/3222
$ git pull https://git.openjdk.java.net/jdk pull/3222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3222

View PR using the GUI difftool:
$ git pr show -t 3222

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3222.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 26, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-jfr label Mar 26, 2021
@egahlin egahlin marked this pull request as ready for review Mar 26, 2021
@openjdk openjdk bot added the rfr label Mar 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 26, 2021

Webrevs

Loading

Copy link

@mgronlun mgronlun left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 29, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264309: JFR: Improve .jfc parser

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 3caea47: 8262739: String inflation C2 intrinsic prevents insertion of anti-dependencies
  • 19a6ac4: 8264142: Remove TRAPS/THREAD parameters for verifier related functions
  • aefc156: 8264179: [TESTBUG] Some compiler tests fail when running without C2
  • 30b4b17: 8264334: Use the blessed modifier order in jdk.jpackage
  • 8ee9a05: 8259623: JfrTypeSet::_subsystem_callback is left dangling after use
  • 1f54ed0: 8264096: slowdebug jvm crashes when StrInflatedCopy match rule is not supported
  • 447e0df: 8263769: simplify PhaseMacroExpand::extract_call_projections()
  • 99b4bab: 8263188: JSSE should fail fast if there isn't supported signature algorithm
  • 6678b01: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2fa6a3c: 8264006: Fix AOT library loading on CPUs with 256-byte dcache line
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/4e74de4b2eec611b49ee8defae1ab06351280008...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 29, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Mar 29, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 29, 2021

@egahlin Since your change was applied there have been 24 commits pushed to the master branch:

  • 364cce1: 8264332: Use the blessed modifier order in jdk.charsets
  • fbbd98b: 8264029: Replace uses of StringBuffer with StringBuilder in java.base
  • 019080e: 8264268: Don't use oop types for derived pointers
  • 3516c26: 8263591: Two C2 compiler phases with the name "after matching"
  • 3caea47: 8262739: String inflation C2 intrinsic prevents insertion of anti-dependencies
  • 19a6ac4: 8264142: Remove TRAPS/THREAD parameters for verifier related functions
  • aefc156: 8264179: [TESTBUG] Some compiler tests fail when running without C2
  • 30b4b17: 8264334: Use the blessed modifier order in jdk.jpackage
  • 8ee9a05: 8259623: JfrTypeSet::_subsystem_callback is left dangling after use
  • 1f54ed0: 8264096: slowdebug jvm crashes when StrInflatedCopy match rule is not supported
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/4e74de4b2eec611b49ee8defae1ab06351280008...master

Your commit was automatically rebased without conflicts.

Pushed as commit 963f1fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants