Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates #3227

Closed
wants to merge 3 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Mar 27, 2021

Please review this cleanup of the allocation list management performed by OopStorage::reduce_deferred_updates. Part of its job is to take a block whose allocation set has changed and update its place in the allocation list accordingly. The old code has somewhat confusing logic and does unnecessary work in some cases. The new code is clearer and avoids that excess work. (I'm not sure what I was thinking when I wrote the old code.)

Testing:
mach5 tier1
I've also been using this patch for some time under other in-development changes that make heavy use of OopStorage.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3227/head:pull/3227
$ git checkout pull/3227

Update a local copy of the PR:
$ git checkout pull/3227
$ git pull https://git.openjdk.java.net/jdk pull/3227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3227

View PR using the GUI difftool:
$ git pr show -t 3227

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3227.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2021

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2021
@openjdk
Copy link

openjdk bot commented Mar 27, 2021

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 27, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem good.

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264324: Simplify allocation list management in OopStorage::reduce_deferred_updates

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2021
@kimbarrett
Copy link
Author

Thanks for reviews @tschatzl and @albertnetymk .

@kimbarrett
Copy link
Author

/integrate

@openjdk openjdk bot closed this Mar 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@kimbarrett Pushed as commit 4ea6abf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the reduce_deferred_updates branch March 30, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants