Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264331: Use the blessed modifier order in jdk.compiler #3235

Closed
wants to merge 1 commit into from

Conversation

@alblue
Copy link
Contributor

@alblue alblue commented Mar 28, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264331: Use the blessed modifier order in jdk.compiler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3235/head:pull/3235
$ git checkout pull/3235

Update a local copy of the PR:
$ git checkout pull/3235
$ git pull https://git.openjdk.java.net/jdk pull/3235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3235

View PR using the GUI difftool:
$ git pr show -t 3235

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3235.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 28, 2021

👋 Welcome back alblue! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 28, 2021

@alblue The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 28, 2021

Webrevs

@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 31, 2021

Would anyone mind reviewing this change, please? It swaps the order of "final static" for "static final" across a bunch of files.

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@alblue This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264331: Use the blessed modifier order in jdk.compiler

Reviewed-by: vromero, iris, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

  • 0228734: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 3997c99: 8264222: Use switch expression in jshell where possible
  • 39f0b27: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total
  • de495df: 8264413: Data is written to file header even if its CRC32 was calculated
  • 52d8a22: 8264054: Bad XMM performance on java.lang.MathBench.sqrtDouble
  • 16acfaf: 8012229: [lcms] Improve performance of color conversion for images with alpha channel
  • cb70ab0: 8263235: sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError
  • e2ec997: 8263551: Provide shared lock-free FIFO queue implementation
  • dec3447: 8264346: nullptr_t undefined in global namespace for clang+libstdc++
  • 0fa3572: 8264489: Add more logging to LargeCopyWithMark.java
  • ... and 53 more: https://git.openjdk.java.net/jdk/compare/a209ed01bafb7721d6b733d1c4bd3f1776463b5e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle, @irisclark, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 31, 2021
@alblue
Copy link
Contributor Author

@alblue alblue commented Mar 31, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@alblue
Your change (at version f7e8aa6) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 1, 2021

/sponsor

@openjdk openjdk bot closed this Apr 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2021

@shipilev @alblue Since your change was applied there have been 63 commits pushed to the master branch:

  • 0228734: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 3997c99: 8264222: Use switch expression in jshell where possible
  • 39f0b27: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total
  • de495df: 8264413: Data is written to file header even if its CRC32 was calculated
  • 52d8a22: 8264054: Bad XMM performance on java.lang.MathBench.sqrtDouble
  • 16acfaf: 8012229: [lcms] Improve performance of color conversion for images with alpha channel
  • cb70ab0: 8263235: sanity/client/SwingSet/src/ColorChooserDemoTest.java failed throwing java.lang.NoClassDefFoundError
  • e2ec997: 8263551: Provide shared lock-free FIFO queue implementation
  • dec3447: 8264346: nullptr_t undefined in global namespace for clang+libstdc++
  • 0fa3572: 8264489: Add more logging to LargeCopyWithMark.java
  • ... and 53 more: https://git.openjdk.java.net/jdk/compare/a209ed01bafb7721d6b733d1c4bd3f1776463b5e...master

Your commit was automatically rebased without conflicts.

Pushed as commit d2df9a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alblue alblue deleted the alblue:Sonar-CompilerModifiers branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants